59429 - Move string code out into its own lib

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Peter "jag" Annema]

And it sounds so simple when you put it like that ;-)

Comment 1

[Scott Collins]

Thanks for filing this bug for me :-)

Comment 2

[Scott Collins]

Here are the files that will move in this change


  source                                      destination

  mozilla/xpcom/ds/bufferRoutines.h           mozilla/string/obsolete/
                   nsStr.cpp
                   nsStr.h
                   nsString.cpp
                   nsString.h
                   nsString2.cpp
                   nsString2.h
                   nsXPIDLString.cpp
                   nsXPIDLString.h

                   nsAlgorithm.h              mozilla/string/public/
                   nsAReadableString.h
                   nsAWritableString.h
                   nsBufferHandle.h
                   nsBufferHandleUtils.h
                   nsCharTraits.h
                   nsFragmentedString.h
                   nsPrintfCString.h
                   nsPrivateSharableString.h
                   nsReadableUtils.h
                   nsSharedBufferList.h
                   nsSharedString.h
                   nsSlidingString.h

                   nsFragmentedString.cpp     mozilla/string/src/
                   nsPrintfCString.cpp
                   nsReadableUtils.cpp
                   nsSharedBufferList.cpp
                   nsSlidingString.cpp

Comment 3

[Johnny Stenback (:jst)]

Attachment: Patch for Makefile.in's in mozilla/xpcom

Comment 4

[Johnny Stenback (:jst)]

Attachment: Patch for makefile.win's in mozilla/xpcom

Comment 5

[Johnny Stenback (:jst)]

Attachment: Top level changes needed to add the string directory to the default build (win & *nix)

Comment 6

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

r=glazman

Comment 7

[Scott Collins]

Attachment: changes to the mac build list to add the string module

Comment 8

[Scott Collins]

last thing to do now is to CVS-remove the string files from their old locations
in xpcom/ds.

Comment 9

[Peter "jag" Annema]

Attachment: [patch] REQUIRES updates

Comment 10

[Peter "jag" Annema]

Apparantly I forgot to clobber at the right point, so that patch is rather
incomplete. Also, waterson just moved some xul stuff from rdf to content, so
I'll come up with an updated patch shortly.

Comment 11

[Peter "jag" Annema]

Attachment: [patch] string, xul REQUIRES updates

Comment 12

[Peter "jag" Annema]

So this should at least get senna green again, I should probably file a bug on
(looking at) cleaning up some of those REQUIRES lines.

I'm not quite sure why I ran into those libimg REQUIRES updates, but I did, so
here they are ;-P

Comment 13

[Johnny Stenback (:jst)]

r=jst for the REQUIRES updates.

Comment 14

[cls]

sr=cls on REQUIRES updates.

Comment 15

[Peter "jag" Annema]

Okay, checked in. I believe we are mostly done with this now, unless you'd like
to keep this open until the string libs are stand-alone?

Comment 16

[Scott Collins]

This is all checked in, so marking fixed.  I've filed a separate bug for making
string build standalone (much lower priority): bug #69854.