594338 - -lmozjs is not available in latest xulrunner SDK... but still present in mozilla-js.pc.in

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Oleg Romashin (:romaxa)]

I think -lmozjs should be removed together with mozilla-js.pc.in file

or  it should have -lmozjs added under some ifdef like ifndef MOZ_LIBXUL or something like that.

Benjamin what is correct way to proceed here?

Comment 1

[Oleg Romashin (:romaxa)]

this is preventing us from native extensions and embedding applications building.

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: Possible fix,

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 473804 [details] [diff] [review]
Possible fix,

maybe we only care about the patch to mozilla-js.pc.in?

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 473804 [details] [diff] [review]
Possible fix,

You need to add MOZ_JS_LINK to the sed command.  r=me with that.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Actually, when js is in libxul, you need to make the flags for js the same as the flags for libxul.

Comment 6

[Oleg Romashin (:romaxa)]

Attachment: Share xul libs

Comment 7

[Oleg Romashin (:romaxa)]

Attachment: Add missing sed part

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 474066 [details] [diff] [review]
Add missing sed part

>+MOZ_XUL_LINK= -lxpcomglue_s -lxul -lxpcom
>+ifdef JS_SHARED_LIBRARY
>+MOZ_JS_LINK= -lmozjs
>+else
>+MOZ_JS_LINK= $(MOZ_XUL_LINK)
>+endif
>+

Nit: lose the spaces after the '='

r=me

Comment 9

[Oleg Romashin (:romaxa)]

Attachment: added missing spaces... comment 8 (PUSH ME)

Comment 10

[Oleg Romashin (:romaxa)]

can we get approval2.0 for that patch? I think distributions will be happy about it
Also Meego mozilla-platform based apps will be happy about proper xulrunner SDK pkgconfig.

Comment 11

[Doug Turner (:dougt)]

Comment on attachment 474068 [details] [diff] [review]
added missing spaces... comment 8 (PUSH ME)

this is a build bustage for people using the mozilla platform.  the test should be that we continue to compile, and these other apps no longer have a problem.  risk is low.

oleg, make sure you run through try before pushing.

Comment 12

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mozilla-central/rev/bd56aa8a39cc

Comment 13

[Tuukka Tolvanen (sp3000)]

Comment on attachment 474068 [details] [diff] [review]
added missing spaces... comment 8 (PUSH ME)

> 	-e "s|%NSPR_VERSION%|$(NSPR_VERSION)|" > $@
>+	-e "s|%MOZ_XUL_LINK%|$(MOZ_XUL_LINK)|" \
>+	-e "s|%MOZ_JS_LINK%|$(MOZ_JS_LINK)|" \
> 	chmod 644 $@

don't think that'll work

Comment 14

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Heh, you are correct.

Comment 15

[Oleg Romashin (:romaxa)]

Attachment: I need to rest :(

Comment 16

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 474710 [details] [diff] [review]
I need to rest :(

Keep the NSPR stuff together please and just move the '> $@' down to the js link line.

Comment 17

[Oleg Romashin (:romaxa)]

Attachment: keep nspr stuff together

Fixed comment

Comment 18

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mozilla-central/rev/045bfb95fe6a