594339 - Turn aFromParser, mParserCreated, etc. from PRUint32 + #defines into an enum

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Henri Sivonen (:hsivonen)]

Variables that indicate whether a node was script-created or parser-created (and how exactly parser-created) should use an enum instead of PRUint32 and these #defines:
http://mxr.mozilla.org/mozilla-central/source/content/base/public/nsContentCreatorFunctions.h#59

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 2

[Henri Sivonen (:hsivonen)]

Comment on attachment 483289 [details] [diff] [review]
Patch v1

r=hsivonen. I noticed that there were some clean-up bits that weren't strictly speaking fixing this bug, but all those clean-ups looked good to me. Thanks for fixing this!

Since I'm not officially qualified to act as a reviewer here, I'm requesting sr.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 483289 [details] [diff] [review]
Patch v1

Looks fine.

Comment 4

[Henri Sivonen (:hsivonen)]

Comment on attachment 483289 [details] [diff] [review]
Patch v1

Requesting approval for 2.0. This is a low-risk patch that'll bitrot extremely quickly. If we don't land this soon, it'll bitrot. OTOH, landing it soon would be harmless.

Comment 5

[Henri Sivonen (:hsivonen)]

Landed with a=jonas as a dependency for bug 604924.
http://hg.mozilla.org/mozilla-central/rev/6aad432efa02

Comment 6

[Henri Sivonen (:hsivonen)]

Doh. I meant bug 604660.