Turn aFromParser, mParserCreated, etc. from PRUint32 + #defines into an enum

RESOLVED FIXED

Status

()

Core
DOM
--
trivial
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: hsivonen, Assigned: Ms2ger)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Variables that indicate whether a node was script-created or parser-created (and how exactly parser-created) should use an enum instead of PRUint32 and these #defines:
http://mxr.mozilla.org/mozilla-central/source/content/base/public/nsContentCreatorFunctions.h#59
(Assignee)

Updated

8 years ago
Assignee: nobody → Ms2ger
(Assignee)

Comment 1

8 years ago
Created attachment 483289 [details] [diff] [review]
Patch v1
Attachment #483289 - Flags: review?(hsivonen)
(Reporter)

Comment 2

8 years ago
Comment on attachment 483289 [details] [diff] [review]
Patch v1

r=hsivonen. I noticed that there were some clean-up bits that weren't strictly speaking fixing this bug, but all those clean-ups looked good to me. Thanks for fixing this!

Since I'm not officially qualified to act as a reviewer here, I'm requesting sr.
Attachment #483289 - Flags: superreview?(bzbarsky)
Attachment #483289 - Flags: review?(hsivonen)
Attachment #483289 - Flags: review+
Comment on attachment 483289 [details] [diff] [review]
Patch v1

Looks fine.
Attachment #483289 - Flags: superreview?(bzbarsky) → superreview+
(Reporter)

Comment 4

8 years ago
Comment on attachment 483289 [details] [diff] [review]
Patch v1

Requesting approval for 2.0. This is a low-risk patch that'll bitrot extremely quickly. If we don't land this soon, it'll bitrot. OTOH, landing it soon would be harmless.
Attachment #483289 - Flags: approval2.0?
(Assignee)

Updated

8 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 5

8 years ago
Landed with a=jonas as a dependency for bug 604924.
http://hg.mozilla.org/mozilla-central/rev/6aad432efa02
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Reporter)

Updated

8 years ago
Attachment #483289 - Flags: approval2.0?
(Reporter)

Comment 6

8 years ago
Doh. I meant bug 604660.
You need to log in before you can comment on or make changes to this bug.