594342 - [SeaMonkey] mochitest-browser-chrome: browser_bug591465.js and browser_searching.js fail

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Serge Gautherie (:sgautherie)]

Remaining/Revealed failures after bug 589659 fix:

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1283943339.1283945703.24249.gz
Linux comm-central-trunk debug test mochitest-other on 2010/09/08 03:55:39
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1283942229.1283943731.13692.gz
OS X 10.5 comm-central-trunk debug test mochitest-other on 2010/09/08 03:37:09
{
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_bug591465.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_bug591465.js | Found a tab after previous test timed out: about:addons

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_searching.js | Should get correct number of results - Got 0, expected 4
...
}

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1283933530.1283937781.11387.gz
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2010/09/08 01:12:10
Same but (intermittent!?) others too
{
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_bug562890.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_bug562890.js | Found a tab after previous test timed out: about:addons

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_bug577990.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_bug577990.js | Found a tab after previous test timed out: about:blank

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_bug581076.js | Test timed out

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_details.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/mozapps/extensions/test/browser/browser_details.js | Found a tab after previous test timed out: about:addons
}

Comment 1

[Robert Kaiser]

Let's please have one bug per issue. browser_bug591465.js and browser_searching.js are pretty surely two different issues, and any (intermittent?) others are probably different again, but could be connected to those persistent failures as well. Debugging intermittent failures only works well once persistent ones are gone or at least down to a very small number...

There might be some connection of failures with the fact that we have preinstalled add-ons, but we should really investigate what those tests are doing.

Comment 2

[Bruno 'Aqualon' Escherl]

Perhaps those failures are related.

get_addon_element(gManagerWindow, "[e-mail]") in the "Searching for remote addons" testcase from browser_bug591465.js returns null instead of a list of search results. browser_searching.js also shows many errors related to not getting the correct number of results (I didn't have a closer look at this test so far).

Comment 3

[Bruno 'Aqualon' Escherl]

Attachment: add SeaMonkey to compatible applications list for search results

Both SeaMonkey tests fail with no search results because SeaMonkey isn't added as compatible application for the test add-ons.

KaiRo: I can't test it myself at the moment, since I have build failures and no time until tomorrow. Could you test it and if it works for you ask mossop for review?

Comment 4

[Robert Kaiser]

Comment on attachment 473130 [details] [diff] [review]
add SeaMonkey to compatible applications list for search results

Haha, sure, let's get reviews for that!

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 473130 [details] [diff] [review]
add SeaMonkey to compatible applications list for search results

Looks good. I guess we could also just change that to be toolkit but I think AMO doesn't support that so this is probably the better test against reality.

Comment 6

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/a26593abc145

Comment 7

[Justin Wood (:Callek)]

Mac: mochitest-browser-chrome: 5059/11/8

was mochitest-browser-chrome: 4824/48/8

VERIFIED, thanks!