fix keyboard shortcuts for Firefox button menu items

VERIFIED FIXED in Firefox 4.0b7

Status

()

Firefox
Menus
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

Trunk
Firefox 4.0b7
All
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
Created attachment 473117 [details] [diff] [review]
fix

There were two errors in the patch for bug 589139:
-"New Tab" in the main menu item should have a tooltip
-"Print...' in the submenu should have a shortcut label
Attachment #473117 - Flags: review?(gavin.sharp)
Comment on attachment 473117 [details] [diff] [review]
fix

doh!
Attachment #473117 - Flags: review?(gavin.sharp)
Attachment #473117 - Flags: review+
Attachment #473117 - Flags: approval2.0+
Assignee: nobody → margaret.leibovic
Keywords: checkin-needed
Created attachment 473362 [details]
This is what I saw in my Firefox Menu

I have highlighted the existence of the New Tab Ctrl+T shortcut in my Firefox Menu.
(Assignee)

Comment 3

7 years ago
Yes, the patch here will fix that once it gets checked in. Thanks again for reporting the problem! :)
You are welcome, Margaret. I am glad I could help out in any way that I can for Firefox 4 development by reporting problems and bug, since I could not help out in writing code as I don't know how to.
(Assignee)

Comment 5

7 years ago
http://hg.mozilla.org/mozilla-central/rev/a0a74e68e82a
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6

Comment 6

7 years ago
Verified fixed using hourly build Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100910 Firefox/4.0b6pre from cset cca361001fda
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.