Closed
Bug 594454
Opened 15 years ago
Closed 15 years ago
fix keyboard shortcuts for Firefox button menu items
Categories
(Firefox :: Menus, defect)
Tracking
()
VERIFIED
FIXED
Firefox 4.0b7
People
(Reporter: Margaret, Assigned: Margaret)
Details
Attachments
(2 files)
|
1.92 KB,
patch
|
Gavin
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
|
160.21 KB,
image/png
|
Details |
This is what I saw in my Firefox Menu
There were two errors in the patch for bug 589139:
-"New Tab" in the main menu item should have a tooltip
-"Print...' in the submenu should have a shortcut label
Attachment #473117 -
Flags: review?(gavin.sharp)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 473117 [details] [diff] [review]
fix
doh!
Attachment #473117 -
Flags: review?(gavin.sharp)
Attachment #473117 -
Flags: review+
Attachment #473117 -
Flags: approval2.0+
|
|
||
Updated•15 years ago
|
Assignee: nobody → margaret.leibovic
Keywords: checkin-needed
|
||
Comment 2•15 years ago
|
||
I have highlighted the existence of the New Tab Ctrl+T shortcut in my Firefox Menu.
|
Assignee | |
Comment 3•15 years ago
|
||
Yes, the patch here will fix that once it gets checked in. Thanks again for reporting the problem! :)
|
|
||
Comment 4•15 years ago
|
||
You are welcome, Margaret. I am glad I could help out in any way that I can for Firefox 4 development by reporting problems and bug, since I could not help out in writing code as I don't know how to.
|
|
Assignee | |
Comment 5•15 years ago
|
||
|
||
Updated•15 years ago
|
Target Milestone: --- → Firefox 4.0b6
Verified fixed using hourly build Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100910 Firefox/4.0b6pre from cset cca361001fda
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•