594572 - String changes for password manager doorhangers (remember, change)

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

Remember password prompt:

Three small changes:

Primary action should be "Remember Password"

Secondary action text should change from "Never for this site" to "Never
Remember Password"

You can remove the secondary option of "not now," since we handle that with the
user ignoring the message.

------------------------------------

Change password prompt:

Primary action should be "Change Password" (So that users can only read the
button and still answer the question).

I think we should also swap two words in the question:

"Would you like to change the password stored for username?"

(instead of stored password)

Comment 1

[Axel Hecht [:Pike]]

To reiterate my comments from bug 567814 comment 31:

"Never Remember Password" sounds like "never for any
site" to me, is that really what we're saying?

As l10n, make sure to add localization notes making it clear that these are
subtle choices of wording in English, as translations may turn out to be way on
the wrong side of life.

Requesting blocking2.0, as I think this is the intention. Not that I'm sure that beltzner agrees on landing things which have blockers as follow-ups, reading dfa.

Comment 2

[:Margaret Leibovic]

Attachment: patch

Comment 3

[:Margaret Leibovic]

Attachment: remember password screenshot

Comment 4

[:Margaret Leibovic]

Attachment: change password screenshot

Comment 5

[Justin Dolske [:Dolske]]

I share Pike's concern, and there's already existing confusion about what this option does (especially wrt to already saved logins on the site). I think we should retain some form of "this site" in the text (I wonder if the geolocation prompt should be tweaked too?).

Also feels like the main text is still too long.

Proposal:

  With username:
  Firefox noticed you sign in as "username" on site.com.

  Without:
  Firefox noticed you sign in on site.com.

  Primary:   Remember Password
  Secondary: Ignore site.com sign-ins

[Maybe that's a bit weak on letting the user know that the _browser_ will store the passwords?]

and
  With username:
  Hmm, Firefox has a different password for "username".

  Without:
  Hmm, Firefox has a different password for this sign-in.

  Primary:   Change password
  Secondary: (none)

Comment 6

[:Margaret Leibovic]

Attachment: alternative patch

Here's an alternative patch with dolske's new ideas.

I also decided not to change the language for the dialogs (they have their own strings), since we're not using them.

Comment 7

[:Margaret Leibovic]

Attachment: alternative remember password screenshot

Comment 8

[:Margaret Leibovic]

Attachment: alternative change password screenshot

Comment 9

[:Margaret Leibovic]

(In reply to comment #5)
I think this may actually be better as:

>   With username:
>   Hmm, Firefox has a different password for "username".

Hmm, Firefox has a different password stored for "username".

>   Without:
>   Hmm, Firefox has a different password for this sign-in.

Hmm, Firefox has a different password stored for this sign-in.

Comment 10

[Justin Dolske [:Dolske]]

Ok, discussed with Faaborg. Main points are to (1) phrase main text as a question and (2) keep button text short.

For (2) the button should probably be "Never for this site", a bit of ambiguity is inevitable but the price of brevity. Hopefully the phrasing of (1) can help, pondering that now.

Comment 11

[:Margaret Leibovic]

Because of bug 595175, I also think we should add the site name to the change
password message. Something to take into consideration.

Comment 12

[Alex Limi (:limi) — Firefox UX Team]

…and here's my attempt at making them as succinct as possible (exploiting some wonderful hacks present in the English language ;)

Proposal:

  With username:
  Remember password for "username" on site.com?

  Without:
  Remember password on site.com?

  Primary:   Remember Password
  Secondary: Never for this site

and
  With username:
  Update saved password for "username"?

  Without:
  Update saved password?

  Primary:   Update password
  Secondary: (none)

Comment 13

[:Margaret Leibovic]

(In reply to comment #12)

I think these are the best options we've come up with so far. However, I propose this change to address comment 11.

>   With username:
>   Update saved password for "username"?

Update saved password for "username" on site.com?

>   Without:
>   Update saved password?

Update saved password on site.com?

Comment 14

[Alex Faaborg [:faaborg] (Firefox UX)]

I would like the secondary action to be a able to stand alone (so the user can read forward and never has to go back for context) but that admitedly makes it longer, so I'm not fully against just having "never for this site". It seems like with geolocation we need to say share location in the secondary actions, since it is privacy sensitive, but either way all of these secondary actions should be consistent in structure.

In terms of saying the domain itself, the overall goal was for this to be implied by the fact that the site identity block was producing the question.  However if we want to add that in for extra context i ok with it.

Comment 15

[Michael Lefevre]

(In reply to comment #14)
> In terms of saying the domain itself, the overall goal was for this to be
> implied by the fact that the site identity block was producing the question. 
> However if we want to add that in for extra context i ok with it.

Don't know if you may have missed it... That implication may be lost because of bug 595175. The site identity shown at the point when the user is seeing the question may not be the same as the site that produced the question.

Comment 16

[:Margaret Leibovic]

I want to be sure I'm making the correct string changes. Is this correct?

Remember:

  With username:
  Remember password for "username" on site.com?

  Without:
  Remember password on site.com?

  Primary:   Remember Password
  Secondary: Never for this site

Change:

  With username:
  Update saved password for "username"?

  Without:
  Update saved password?

  Primary:   Update password
  Secondary: (none)

Comment 17

[Alex Faaborg [:faaborg] (Firefox UX)]

>Never for this site

I would like to go with "Never remember password for this site"

similarly:

"Always share location with this site"
"Never share location with this site"

These are long, but since they appear in a menu off of the button, they don't provide increased visual complexity until they are accessed.  Also, when the user clicks them they never have to go back for context, and it is completely clear what the action does.

Comment 18

[:Margaret Leibovic]

Attachment: patch v2

Comment 19

[:Margaret Leibovic]

Attachment: remember password screenshot (patch v2)

Comment 20

[:Margaret Leibovic]

Attachment: change password screenshot (patch v2)

Comment 21

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 474921 [details]
remember password screenshot (patch v2)

both primary action and secondary action should be in title case, otherwise ui-r+

Comment 22

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 474922 [details]
change password screenshot (patch v2)

primary action should be in title case, otherwise ui-r+

Comment 23

[Justin Dolske [:Dolske]]

Comment on attachment 474920 [details] [diff] [review]
patch v2

>+++ b/toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties
...
> # 1st string is product name, 2nd is the username for the login, 3rd is the
> #   login's hostname. Note that long usernames may be truncated.
>-saveLoginText = Do you want %1$S to remember the password for "%2$S" on %3$S?
>+rememberPasswordText = Remember password for "%1$S" on %2$S?

The comment is wrong now. Make it a "LOCALIZATION NOTE (rememberPasswordText)" while you're here?

> # 1st string is product name, 2nd is the login's hostname
>-saveLoginTextNoUsername = Do you want %1$S to remember this password on %2$S?
>+rememberPasswordTextNoUsername = Remember password on %S?

Ditto.

>+updatePasswordText = Update saved password for "%S"?

Should probably add a note here too, saying that it's the username.

And, as alex noted, Title Case the buttons.

r+ with that.

Comment 24

[:Margaret Leibovic]

Attachment: patch v3

Final patch.

Comment 25

[:Margaret Leibovic]

http://hg.mozilla.org/mozilla-central/rev/1003078db0a8