Closed Bug 594613 Opened 10 years ago Closed 10 years ago

Fastload not invalidated after building with pymake

Categories

(Toolkit Graveyard :: Build Config, defect)

x86
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: zpao, Assigned: benedict)

References

Details

Attachments

(1 file, 1 obsolete file)

`python -O ../build/pymake/make.py -C browser/components`

is not causing my fastload to be invalidated. This is a debug build.

.purgecaches is not being created.
Assignee: nobody → bhsieh
I've been told that make.py should still pass the 
|if test -d ../dist/bin ; then touch ../dist/bin/.purgecaches ; fi|
command to the shell. I wonder if MozillaBuild maybe doesn't support one of the commands in there?
Seems pretty unlikely.
Noticed that on Windows, this line doesn't show up at all when I do make:
>  if test -d $(DIST)/bin ; then touch $(DIST)/bin/.purgecaches ; fi
and it does on other platforms.

The line comes from http://mxr.mozilla.org/mozilla-central/source/config/rules.mk#2360 or the rules.mk file in /js.
http://mozilla.pastebin.com/u8Wcbh1S is the tail end of the output from make -d. 
Looks like that line isn't getting executed at all. From here, I'm not sure what to do other than muck around with Makefiles to see if I can find something Windows make is happy with.
So, looks like using the libs target instead of the default target works. I don't remember if only invalidating on make libs misses any corner cases, but I think it should be ok.
Attachment #474276 - Flags: review?(benjamin)
Attachment #474276 - Flags: approval2.0?
Attachment #474276 - Flags: review?(benjamin)
Attachment #474276 - Flags: review-
Attachment #474276 - Flags: approval2.0?
Attachment #474276 - Attachment is obsolete: true
Attachment #475345 - Flags: approval2.0?
Attachment #475345 - Flags: approval2.0? → approval2.0+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7
Blocks: 603866
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.