594613 - Fastload not invalidated after building with pymake

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

`python -O ../build/pymake/make.py -C browser/components`

is not causing my fastload to be invalidated. This is a debug build.

.purgecaches is not being created.

Comment 1

[Benedict Hsieh [:benedict]]

I've been told that make.py should still pass the 
|if test -d ../dist/bin ; then touch ../dist/bin/.purgecaches ; fi|
command to the shell. I wonder if MozillaBuild maybe doesn't support one of the commands in there?

Comment 2

[(not currently active) Ted Mielczarek]

Seems pretty unlikely.

Comment 3

[Benedict Hsieh [:benedict]]

Noticed that on Windows, this line doesn't show up at all when I do make:
>  if test -d $(DIST)/bin ; then touch $(DIST)/bin/.purgecaches ; fi
and it does on other platforms.

The line comes from http://mxr.mozilla.org/mozilla-central/source/config/rules.mk#2360 or the rules.mk file in /js.

Comment 4

[Benedict Hsieh [:benedict]]

http://mozilla.pastebin.com/u8Wcbh1S is the tail end of the output from make -d. 
Looks like that line isn't getting executed at all. From here, I'm not sure what to do other than muck around with Makefiles to see if I can find something Windows make is happy with.

Comment 5

[Benedict Hsieh [:benedict]]

So, looks like using the libs target instead of the default target works. I don't remember if only invalidating on make libs misses any corner cases, but I think it should be ok.

Comment 6

[Benedict Hsieh [:benedict]]

Attachment: use libs target instead of default target

Comment 7

[Benedict Hsieh [:benedict]]

Attachment: uses default all instead of default

Comment 8

[Benedict Hsieh [:benedict]]

http://hg.mozilla.org/mozilla-central/rev/2c0e939c9cef