If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fastload not invalidated after building with pymake

RESOLVED FIXED in mozilla2.0b7

Status

()

Toolkit
Build Config
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: zpao, Assigned: benedict)

Tracking

unspecified
mozilla2.0b7
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

`python -O ../build/pymake/make.py -C browser/components`

is not causing my fastload to be invalidated. This is a debug build.

.purgecaches is not being created.
(Assignee)

Updated

7 years ago
Assignee: nobody → bhsieh
(Assignee)

Comment 1

7 years ago
I've been told that make.py should still pass the 
|if test -d ../dist/bin ; then touch ../dist/bin/.purgecaches ; fi|
command to the shell. I wonder if MozillaBuild maybe doesn't support one of the commands in there?
Seems pretty unlikely.
(Assignee)

Comment 3

7 years ago
Noticed that on Windows, this line doesn't show up at all when I do make:
>  if test -d $(DIST)/bin ; then touch $(DIST)/bin/.purgecaches ; fi
and it does on other platforms.

The line comes from http://mxr.mozilla.org/mozilla-central/source/config/rules.mk#2360 or the rules.mk file in /js.
(Assignee)

Comment 4

7 years ago
http://mozilla.pastebin.com/u8Wcbh1S is the tail end of the output from make -d. 
Looks like that line isn't getting executed at all. From here, I'm not sure what to do other than muck around with Makefiles to see if I can find something Windows make is happy with.
(Assignee)

Comment 5

7 years ago
So, looks like using the libs target instead of the default target works. I don't remember if only invalidating on make libs misses any corner cases, but I think it should be ok.
(Assignee)

Comment 6

7 years ago
Created attachment 474276 [details] [diff] [review]
use libs target instead of default target
Attachment #474276 - Flags: review?(benjamin)
Attachment #474276 - Flags: approval2.0?

Updated

7 years ago
Attachment #474276 - Flags: review?(benjamin)
Attachment #474276 - Flags: review-
Attachment #474276 - Flags: approval2.0?
(Assignee)

Comment 7

7 years ago
Created attachment 475345 [details] [diff] [review]
uses default all instead of default
Attachment #474276 - Attachment is obsolete: true
Attachment #475345 - Flags: approval2.0?

Updated

7 years ago
Attachment #475345 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 8

7 years ago
http://hg.mozilla.org/mozilla-central/rev/2c0e939c9cef
(Assignee)

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Target Milestone: --- → mozilla2.0b7

Updated

7 years ago
Blocks: 603866
You need to log in before you can comment on or make changes to this bug.