This actually looks fairly serious. Moving back to M6
According to John, Mail is also broken because mail depends on reading the pref50.js file.
Fixed. This fix will appear in today's final Macintosh build.
Using the May 5 1999-05-05-15 build, the preference file is now being read on the Mac. Mail folders and messages now appears again. This bug is verified on Mail. Leaving this bug for Paulmac to verify on the browser issue. Great work John! :)
Verified - you can set prefs via the UI and they show up just swell the next time you run.
Removing the word "stopper" from the summary.
Adding myself as cc:
Checked in a fix. (aargh, forgot to credit the excellent sleuthing in the log. Sorry!) Turns out that this problem appeared when we removed the JSFILE (read js source from a filehandle) #ifdef. In the from-a-file case (only) we read the file into a circular buffer. js handles \r \n \r\n by collapsing to \n in the buffer, but it has to special-case \r ending a buffer. The code ran into trouble when \r\r ended the buffer; it tried to advance the reading pointer past the end marker, and then (because of an ==, not >, check) it merrily read on from there. Fixed in two ways: - This check now doesn't fire at all unless we're reading from a file. This means that all mozilla code prior to the removal of the JSFILE #ifdef is OK. (jband?) I'm sure this fixes the non-file case. - Added a recursive GetChar() call to escape out of the \r buffer-ending check and start over whenever we're in the accidental-overflow case. I'm mostly sure this fixes the file case.
Pter, can you verify the fix? Thanks. Prefs still look good, but you were seeing some initialization problems.
Prefs are read in, JS bug is gone. I think this bug is resolved. Last thing to do: remove John's workaround in macpref.cp (line 109 to 111 and line 135).
Yes, and I have some changes in my tree. However, the remaining bug is really subsumed under bug #5132. So I'm now marking this as a duplicate, in order to make use of Bugzilla's nifty cross-linking feature.
Reopened, then marked as a duplicate. *** This bug has been marked as a duplicate of 5132 ***