594707 - [MacOSX SeaMonkey] mochitest-browser-chrome: "browser_visituri.js | Test timed out"

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Serge Gautherie (:sgautherie)]

Ftr, up to
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1281293461.1281294534.30768.gz
OS X 10.5 comm-central-trunk debug test mochitest-other on 2010/08/08 11:51:01
{
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/places/tests/browser/browser_visituri.js | Exception thrown at chrome://mochikit/content/browser/toolkit/components/places/tests/browser/browser_visituri.js:46 - ReferenceError: PlacesUtils is not defined
}

Since then (probably after the previous error got fixed):
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1281304302.1281305839.15090.gz
OS X 10.5 comm-central-trunk debug test mochitest-other on 2010/08/08 14:51:42
{
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/places/tests/browser/browser_visituri.js | Timed out
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/places/tests/browser/browser_visituri.js | Found a tab after previous test timed out: http://example.com/tests/toolkit/components/places/tests/browser/begin.html
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/places/tests/browser/browser_visituri.js | Saved URL visit http://example.com/tests/toolkit/components/places/tests/browser/final.html - Got http://example.com/tests/toolkit/components/places/tests/browser/final.html, expected http://example.com/tests/toolkit/components/places/tests/browser/redirect_twice.sjs
}

Likely "cause":
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1284011341.1284012797.26154.gz&fulltext=1
OS X 10.5 comm-central-trunk debug test mochitest-other on 2010/09/08 22:49:01
{
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "aCallback is not a function" {file: "chrome://mochikit/content/browser/toolkit/components/places/tests/browser/browser_settitle.js" line: 61}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///builds/slave/comm-central-trunk-macosx-debug-unittest-mochitest-other/build/SeaMonkeyDebug.app/Contents/MacOS/components/nsPlacesExpiration.js :: PEX_handleCompletion :: line 679"  data: yes]
...
JavaScript error: chrome://mochikit/content/tests/SimpleTest/EventUtils.js, line 60: aTarget is null
TEST-INFO | chrome://mochikit/content/browser/toolkit/components/places/tests/browser/browser_visituri.js | Console message: [JavaScript Error: "aCallback is not a function" {file: "chrome://mochikit/content/browser/toolkit/components/places/tests/browser/browser_settitle.js" line: 61}]
TEST-INFO | chrome://mochikit/content/browser/toolkit/components/places/tests/browser/browser_visituri.js | Console message: [JavaScript Error: "aTarget is null" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 60}]
}
Note that an error "from" previous (passing) browser_settitle.js test seems to leak to browser_visituri.js :-(
Maybe the former test is not cleaning up correctly after itself?
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/tests/browser/browser_settitle.js

NB: I don't know why we get this failure (on MacOSX only).

Comment 1

[Justin Wood (:Callek)]

Ok, part of the problem is that we _call_ finish() as the the callback to waitForClearHistory rather than passing the function ref.

Comment 2

[Justin Wood (:Callek)]

Attachment: properly pass finish [Checked in: Comment 3]

The initial test messed this up, it is basically timing related it seems.

Comment 3

[Ian Neal]

Comment on attachment 474322 [details] [diff] [review]
properly pass finish [Checked in: Comment 3]

http://hg.mozilla.org/mozilla-central/rev/3c43aa9d0051

Comment 4

[Serge Gautherie (:sgautherie)]

Ftr, it looks like since (2010.09.15 ...)
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a42e7aef9a62&tochange=b8222ba37b0f
this failure had become intermittent...