594849 - Need way to pick up on valgrind in testconfig.txt

Status: RESOLVED FIXED

(Tamarin Graveyard :: Build Config, defect)

Comment 1

[Tommy Reilly]

Attachment: tack on -valgrind to AVMPLUS_BIN_TYPE

Comment 2

[Edwin Smith]

Can you elaborate on the bug this is fixing?

Is it that runtests.py doesn't work right if you specify -E "valgrind avmplus ...", or that we need to know if it's valgrind to enable valgrind-specific test suppressions?

Comment 3

[Tommy Reilly]

Attachment: VM changes w/ testconfig changes

This is a complete patch that shows what I'm going for.

Comment 4

[Edwin Smith]

Comment on attachment 473619 [details] [diff] [review]
tack on -valgrind to AVMPLUS_BIN_TYPE

do you want this to be a binary type or a feature?  

need a space between if and (RUNNING_ON_VALGRIND)

The extra call to AvmLog will format weridly if any custom log function automatically adds newline.  it shouldn't, but caution.  a conditional
expression wouldn't take the chance:

  (RUNNING_ON_VALGRIND ? "-valgrind" : "")

Comment 5

[Tommy Reilly]

(In reply to comment #4)
> do you want this to be a binary type or a feature?  

It doesn't feel like a feature to me, I have --enable-valgrind to compile in the client requests get the OPT_CXXFLAGS right but haven't made it a full fledged feature.   Also even if --enable-valgrind is on we only want to do these testconfig exclusion if we are in fact running on valgrind.
 
> The extra call to AvmLog will format weridly if any custom log function
> automatically adds newline.  it shouldn't, but caution.  a conditional
> expression wouldn't take the chance:
> 
>   (RUNNING_ON_VALGRIND ? "-valgrind" : "")

But that expression is a bunch of const strings being concated together at compile time, a runtime expression wouldn't work there.

Comment 6

[Brent Baker]

Comment on attachment 473670 [details] [diff] [review]
VM changes w/ testconfig changes

I would probably tweak the testconfig to just be .*valgrind.* , that is assuming that these tests also need to be skipped on x64

Comment 7

[Tommy Reilly]

I haven't run on mac-x64 or lnx yet, I don't want to relax the wild cards until I know I need to