Closed Bug 595009 Opened 11 years ago Closed 11 years ago

Video controls don't show error UI when source element is in error

Categories

(Core :: Audio/Video, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- final+

People

(Reporter: kinetik, Assigned: cpearce)

References

Details

(Keywords: regression)

Attachments

(2 files)

Attached file testcase
Not sure if this is a controls bug or a regression caused by bug 485288.  The controls work fine if the video-in-error is specified as the video @src.

Testcase attached.  Testcase works correctly in Firefox 3.6, but is broken in trunk nightlies.
I suspect this is caused by video.error being null, which causes the controls not to show the error state... but I haven't investigated yet.
blocking2.0: --- → ?
Keywords: regression
Assignee: nobody → kinetik
This is fixed by the patches in bug 505158.
Depends on: 505158
Bug 505158 has landed, so we now show the gray-error status box with the testcase above. But I just noticed that if I mouseover the video element, we'll display the controls and they never fade out. :(
I'll take this, as I've fixed a bunch of similar bugs recently.
Assignee: kinetik → chris
Status: NEW → ASSIGNED
Attached patch PatchSplinter Review
* Ensure the controls don't show when we're unable to load from source children.
Attachment #486175 - Flags: review?(dolske)
Attachment #486175 - Flags: review?(dolske) → review+
http://hg.mozilla.org/mozilla-central/rev/2bd86fdd9c62
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.