Last Comment Bug 595022 - Remove JS_SealObject
: Remove JS_SealObject
: dev-doc-complete
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
-- normal (vote)
: ---
Assigned To: Jim Blandy :jimb
: Jason Orendorff [:jorendorff]
Depends on: 492849
  Show dependency treegraph
Reported: 2010-09-09 16:53 PDT by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2012-04-28 12:00 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Description User image Jeff Walden [:Waldo] (remove +bmo to email) 2010-09-09 16:53:19 PDT
The name's wrong, its semantics don't match those of the nearest ES5-alike method Object.freeze, and its "deep" argument (to seal entire object graphs) is prone to runaway (the handling of which should be a user-chosen policy, not one imposed from on high by the JSAPI).

This depends on bug 492849 landing first, to add JS_FreezeObject as an ES5-approved alternative.  I won't be able to fix this bug unless we're fine sitting on this bug for a couple weeks, due to a vacation without computer or net access.
Comment 1 User image Jim Blandy :jimb 2010-09-16 11:38:44 PDT
I've renamed this JS_DeepFreezeObject, and removed the 'deep' argument, making the function always recurse; this is consistent with JS_FreezeObject, which is in turn consistent with ES5.
Comment 2 User image Jeff Walden [:Waldo] (remove +bmo to email) 2012-04-28 12:00:50 PDT
Fixed long ago, removal documented in release notes and on the JS_SealObject page itself:

Note You need to log in before you can comment on or make changes to this bug.