595054 - Crash Reporter layout adjustment code fails for some locales

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Screenshot

STR:

1) Crash Camino 2.0.4 ML while running in certain non-English locales, e.g., French (testcase in bug 411930 will crash for you if you don't have a favorite crash available).
2) Look at the "row" that contains the email address field and the privacy policy thingy.
3) Weep.

AR: Privacy policy thingy's text label overlaps the email address field.
ER: No weeping and no overlap.

I never re-tested the crash reporter in all locales after we turned email on (only a handful with apparently-short privacy policy labels), so I never caught it.  (I'm a little surprised no-one at Google caught it, either.)

Comment 1

[Stuart Morgan]

Ugh :( I guess we didn't plan for collision.

Comment 2

[Stuart Morgan]

Fix out for review:
http://breakpad.appspot.com/247001

We're probably overdue for a breakpad roll anyway, so once that lands we should roll forward rather than cherry-picking (assuming a sanity test of the latest build looks good in our tree)

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #2)
> We're probably overdue for a breakpad roll anyway, so once that lands we should
> roll forward rather than cherry-picking (assuming a sanity test of the latest
> build looks good in our tree)

Sounds good to me.  However, we (you) should ping mento on http://breakpad.appspot.com/163001/show / http://code.google.com/p/google-breakpad/issues/detail?id=397 ; we'll need that fixed for at least OS symbol generation (and maybe for fallback symbols? I forget), and I'd rather not have to keep a separate dump_syms around, and modify all my scripts, for that.

Comment 4

[Stuart Morgan]

Fix landed (as r749 in case we decide to cherry-pick).

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Per irc, we should cherry-pick this now (and for 2.0.7) and then open a new bug on getting an updated Breakpad pull for 2.1 (soon after a1?).

Since the fix we're taking here has r=mento upstream, I see no need for additional reviews before landing ;)

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/c1d8d265ce9a and CAMINO_2_0_BRANCH.

I did a small merge of CGFloat->float, since our pull is pre-introduction of CGFloat in Breakpad, and updated the README to mention this bug.

I filed bug 633865 on getting an updated pull for 2.1.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

2.0.7 ended up being an emergency release.