Package dom_notification.xpt

VERIFIED FIXED in seamonkey2.1b1

Status

SeaMonkey
Installer
--
major
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

(Blocks: 1 bug)

Trunk
seamonkey2.1b1
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Bug 573588 added dom_notification.xpt and a bunch of DOM tests recently, and we are not packaging it. We should just include it.
(Assignee)

Comment 1

7 years ago
Created attachment 474142 [details] [diff] [review]
Patch v1.0 Just add it.
Attachment #474142 - Flags: review?(bugspam.Callek)
Comment on attachment 474142 [details] [diff] [review]
Patch v1.0 Just add it.

rs+ if it fixes tests, but I somehow think this depends on doorhangers and real navigator.xul changes from a skim of the bug that added this.
Attachment #474142 - Flags: review?(bugspam.Callek)
Attachment #474142 - Flags: review+
Attachment #474142 - Flags: feedback?(kairo)

Comment 3

7 years ago
gah, and I hoped I could escape looking into this review more deeply. I probably will not be able to do any meaningful work like digging into bugs until Monday.
Comment on attachment 474142 [details] [diff] [review]
Patch v1.0 Just add it.

Hmm this is not actually app-specific in any way. [yet]

Please open a new bug to track Bug 594543
Attachment #474142 - Flags: feedback?(kairo)
http://hg.mozilla.org/comm-central/rev/255597f9251d
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

7 years ago
> rs+ if it fixes tests, but I somehow think this depends on doorhangers and real
> navigator.xul changes from a skim of the bug that added this.

Reading the patches that got checked in, everything else is either backend or Fennec specific. The front end UI changes to Firefox were not checked in (r-) but deferred to after Gecko 2.0.
(Assignee)

Comment 7

7 years ago
> Please open a new bug to track Bug 594543
I filed Bug 595437 [Tracking] Implement Desktop Notifications in SeaMonkey
(Assignee)

Updated

7 years ago
Blocks: 595437
This did fix (bug 595024 comment 3) mochitests-3/5 failures.

V.Fixed, per
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1284179343.1284181265.28030.gz
Linux comm-central-trunk debug test mochitests-3/5 on 2010/09/10 21:29:03
Blocks: 452942
Severity: normal → major
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.