595273 - Package dom_notification.xpt

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Philip Chee]

Bug 573588 added dom_notification.xpt and a bunch of DOM tests recently, and we are not packaging it. We should just include it.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Just add it.

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 474142 [details] [diff] [review]
Patch v1.0 Just add it.

rs+ if it fixes tests, but I somehow think this depends on doorhangers and real navigator.xul changes from a skim of the bug that added this.

Comment 3

[Robert Kaiser]

gah, and I hoped I could escape looking into this review more deeply. I probably will not be able to do any meaningful work like digging into bugs until Monday.

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 474142 [details] [diff] [review]
Patch v1.0 Just add it.

Hmm this is not actually app-specific in any way. [yet]

Please open a new bug to track Bug 594543

Comment 5

[Justin Wood (:Callek)]

http://hg.mozilla.org/comm-central/rev/255597f9251d

Comment 6

[Philip Chee]

> rs+ if it fixes tests, but I somehow think this depends on doorhangers and real
> navigator.xul changes from a skim of the bug that added this.

Reading the patches that got checked in, everything else is either backend or Fennec specific. The front end UI changes to Firefox were not checked in (r-) but deferred to after Gecko 2.0.

Comment 7

[Philip Chee]

> Please open a new bug to track Bug 594543
I filed Bug 595437 [Tracking] Implement Desktop Notifications in SeaMonkey

Comment 8

[Serge Gautherie (:sgautherie)]

This did fix (bug 595024 comment 3) mochitests-3/5 failures.

V.Fixed, per
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1284179343.1284181265.28030.gz
Linux comm-central-trunk debug test mochitests-3/5 on 2010/09/10 21:29:03