Closed Bug 595273 Opened 9 years ago Closed 9 years ago

Package dom_notification.xpt

Categories

(SeaMonkey :: Installer, defect, major)

defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED
seamonkey2.1b1

People

(Reporter: philip.chee, Assigned: philip.chee)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 573588 added dom_notification.xpt and a bunch of DOM tests recently, and we are not packaging it. We should just include it.
Attachment #474142 - Flags: review?(bugspam.Callek)
Comment on attachment 474142 [details] [diff] [review]
Patch v1.0 Just add it.

rs+ if it fixes tests, but I somehow think this depends on doorhangers and real navigator.xul changes from a skim of the bug that added this.
Attachment #474142 - Flags: review?(bugspam.Callek)
Attachment #474142 - Flags: review+
Attachment #474142 - Flags: feedback?(kairo)
gah, and I hoped I could escape looking into this review more deeply. I probably will not be able to do any meaningful work like digging into bugs until Monday.
Comment on attachment 474142 [details] [diff] [review]
Patch v1.0 Just add it.

Hmm this is not actually app-specific in any way. [yet]

Please open a new bug to track Bug 594543
Attachment #474142 - Flags: feedback?(kairo)
http://hg.mozilla.org/comm-central/rev/255597f9251d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
> rs+ if it fixes tests, but I somehow think this depends on doorhangers and real
> navigator.xul changes from a skim of the bug that added this.

Reading the patches that got checked in, everything else is either backend or Fennec specific. The front end UI changes to Firefox were not checked in (r-) but deferred to after Gecko 2.0.
> Please open a new bug to track Bug 594543
I filed Bug 595437 [Tracking] Implement Desktop Notifications in SeaMonkey
Blocks: 595437
This did fix (bug 595024 comment 3) mochitests-3/5 failures.

V.Fixed, per
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1284179343.1284181265.28030.gz
Linux comm-central-trunk debug test mochitests-3/5 on 2010/09/10 21:29:03
Blocks: SmTestFail
Severity: normal → major
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.