595284 - about:support is broken in fennec

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

The page uses fuel, which fennec doens't support. We should either fix the page or add fuel support to fennec (bug 455514)

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The patch just override the default aboutSupport.xhtml page to add the missing part called by aboutSupport.js.
But since there is only a few stuff to change to get rid of FUEL dependancy into aboutSupport.xhtml I vote for changing it.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Platform patch

And here the platform patch if we prefer to change aboutSupport.js directly!

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 474358 [details] [diff] [review]
Platform patch

This patch looks good to me. It removes the FUEL dependencies and adds support for Services.jsm, which keeps things very readable.

The getPrefValue method is only cruft added and it is minimal imo.

Passing to gavin for toolkit review.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

fwiw, it seems like a better idea to fix this in the platform rather than in fennec. Otherwise, we'll have trouble keeping it in sync.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #4)
> fwiw, it seems like a better idea to fix this in the platform rather than in
> fennec. Otherwise, we'll have trouble keeping it in sync.

Agreed. I think Gavin feels the same way. I'll obsolete the fork patch.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/51d668e25e2c

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

v. Mozilla/5.0 (Android; Linux armv7l; rv:2.0b13pre) Gecko/20110314 Firefox/4.0b13pre Fennec/4.0b6pre ID:20110314043938

Comment 8

[Dão Gottwald [:dao]]

bugspam