595348 - Nautilus theme gets deselected on restart after removing Persona

Status: VERIFIED INVALID

(Mozilla Labs Graveyard :: Personas Plus, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Using Personas 1.6.1 on Windows XP w/Firefox 3.6.9, and installing the Nautilus theme with a Persona, when I uninstall the Persona, the Nautilus theme gets deselected on restart.

See screencast: http://screencast.com/t/Mzc1NjgxNDgt

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

And, to be clear, |lightweightThemes.forceSkinning| is set to |true|.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Jose, can you please take a look at this?  Maybe it's a Firefox 3.6.9 bug, or something you could potentially fix.  Thanks.

Comment 3

[Carsten Book [:Tomcat]]

note, was not able to reproduce

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #3)
> note, was not able to reproduce

Windows or Mac?  Same build -- 3.6.9?

Comment 5

[Carsten Book [:Tomcat]]

(In reply to comment #4)
> (In reply to comment #3)
> > note, was not able to reproduce
> 
> Windows or Mac?  Same build -- 3.6.9?

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.9) Gecko/20100824 Firefox/3.6.9  and also mac and windows

Comment 6

[Nils Maier [:nmaier]]

You're using https://addons.mozilla.org/en-US/firefox/addon/9524/. That addon observer lightweight-theme-changed in btOverlay.xul, and sets a preference "bigBoom" to true when no persona is selected anymore, i.e. after you uninstall the persona in the screencast.
Upon restart, btServiceUtilities.js::profileAfterChange is called (included via btClientService.js), which sees "bigBoom" = true and hence resets the theme to classic/1.0.

This is a hence a problem of that BrandThunder addon, not a bug in Personas Plus.

Comment 7

[Mike Kaply [:mkaply]]

We're moving all our themes to a new architecture that integrates better with Personas, so problems like this should go away.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Thanks for the explanation, Nils!  Happy to mark this invalid.