Closed Bug 595403 Opened 10 years ago Closed 10 years ago

[mobile2] Can't scroll up after orientation change or resize

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

defect
Not set

Tracking

(fennec2.0b1+)

VERIFIED FIXED
Tracking Status
fennec 2.0b1+ ---

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Keywords: qablocker)

Attachments

(1 file)

Steps to reproduce (using the "mobile2" tileless branch):

1. Open a tall page, e.g. http://planet.mozilla.org/
2. Scroll down toward the bottom of page.
3. Change orientation. (On desktop, resize the window or use ctrl-shift-q.)
4. Scroll back up toward the top of the page.

Expected results: As you swipe down the screen, the page scrolls up until it reaches the top.

Actual results: As you swipe down the screen, the urlbar appears and then the page stops scrolling, even though it is not at the top.
Blocks: 576192
tracking-fennec: --- → ?
tracking-fennec: ? → 2.0b1+
For some reason after resizing, the #tile-stack element sometimes keeps its old height instead of resizing with the window.  This breaks _panControlsAwayOffset.

I have also seen some odd unreproducible behavior where pressing control-shift-q causes the window to toggle rapidly from portrait to landscape and then back, or to resize only after you click in the window.  I'm just not sure what's happening here.
Assignee: nobody → mbrubeck
Keywords: qablocker
Attached patch FixSplinter Review
Attachment #476414 - Flags: review?(mbrubeck)
Comment on attachment 476414 [details] [diff] [review]
Fix

>+++ b/chrome/content/bindings/browser.xml      Fri Sep 17 15:46:51 2010 -0700
>@@ -149,6 +149,7 @@
>             case "MozScrolledAreaChanged":
>               this._contentDocumentWidth = aMessage.json.width;
>               this._contentDocumentHeight = aMessage.json.height;
>+              this.scrollBy(0, 0);

Can you add another XXX comment here?

>+      // XXX page scrollbox jumps to a strange value on resize. Scrolling it will
>+      // bound it to a sane place, but not where we were when the resize began :(
>+      Browser.hideTitlebar();
>+
>+      // XXX Hack. Browser also behaves badly on resize.
>+      getBrowser().style.display = "none";
>+      getBrowser().style.display = "block";

Ugh.  Well, it works for beta.  Could you file a followup bug and reference it in the comments?
Attachment #476414 - Flags: review?(mbrubeck) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
verified FIXED on builds:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b6pre) Gecko/20100920 Namoroka/4.0b7pre Fennec/2.0b1pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b6pre) Gecko/20100920 Namoroka/4.0b7pre Fennec/2.0b1pre



follow-up bug filed for multi-finger gestures: https://bugzilla.mozilla.org/show_bug.cgi?id=598033
Status: RESOLVED → VERIFIED
Depends on: 597580
You need to log in before you can comment on or make changes to this bug.