Closed Bug 595459 Opened 9 years ago Closed 9 years ago

JarMaker.py can fail to install files in symlink or flat chrome on weird systems

Categories

(Firefox Build System :: General, defect)

All
Other
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

I'm (ab)using the build system to install branding files in a flat chrome and compare unofficial branding and iceweasel branding that way. It turns out this failed on Hurd (the weird system), because it is the only system I know of where ENOENT is not 2. As JarMaker.py tests errno to 2 instead of the symbolic errno.ENOENT, it fails.

I checked all others python files for the use of errno, and it appears JarMaker is the only one using numbers directly.
Attachment #474344 - Flags: review?(benjamin)
Attachment #474344 - Flags: review?(benjamin) → review+
Attachment #474344 - Flags: approval2.0?
Attachment #474344 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/15547474a462
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.