Closed Bug 595513 Opened 9 years ago Closed 9 years ago

Reduce makefile recursion

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Mitch, Assigned: Mitch)

References

Details

Attachments

(1 file, 6 obsolete files)

Like bug 542222 and bug 461444 before it, recursion in makefiles can be reduced. I intend to add multiple patches for this.
Attachment #474380 - Flags: review?(khuey)
Comment on attachment 474380 [details] [diff] [review]
toolkit/mozapps and toolkit/profile

This is fine as long as the moves are done as moves and we don't break hg history like what happened last time.
Attachment #474380 - Flags: review?(khuey) → review+
With the right patch this time.
Attachment #474380 - Attachment is obsolete: true
Attachment #474381 - Flags: review?(khuey)
Attached patch toolkit/components (obsolete) — Splinter Review
Attachment #474399 - Flags: review?(khuey)
Comment on attachment 474381 [details] [diff] [review]
toolkit/mozapps and toolkit/profile (v2)

How is toolkit/mozapps/jar.mn getting processed when you are no longer building in toolkit/mozapps (and since you aren't why isn't toolkit/mozapps/Makefile.in getting removed?)
Ah, that's a good point.  Perhaps we can move it to the toplevel directory or something.
I'd probably prefer moving them into their respective directories, right now some thing in toolkit/mozapps use their own jar.mn and some don't. Might as well make them all do the same
Attached patch toolkit (obsolete) — Splinter Review
This patch folds in the toolkit/profile changes and includes mozapps changes Mossop suggested.
Attachment #474381 - Attachment is obsolete: true
Attachment #474399 - Attachment is obsolete: true
Attachment #474483 - Flags: review?(khuey)
Attachment #474399 - Flags: review?(khuey)
Comment on attachment 474483 [details] [diff] [review]
toolkit

This doesn't seem to contain the new jar.mn files.
Comment on attachment 474483 [details] [diff] [review]
toolkit

Indeed.
Attachment #474483 - Attachment is obsolete: true
Attachment #474483 - Flags: review?(khuey)
Attached patch toolkit (v2) (obsolete) — Splinter Review
Attachment #474558 - Flags: review?(khuey)
Attachment #474558 - Flags: feedback?(dtownsend)
Comment on attachment 474558 [details] [diff] [review]
toolkit (v2)

This is broken. I'll get it right one of these days...
Attachment #474558 - Attachment is obsolete: true
Attachment #474558 - Flags: review?(khuey)
Attachment #474558 - Flags: feedback?(dtownsend)
Attached patch toolkit (v3) (obsolete) — Splinter Review
I'd previously botched paths in the jar manifests.
Attachment #474563 - Flags: review?(khuey)
Attachment #474563 - Flags: feedback?(dtownsend)
Comment on attachment 474563 [details] [diff] [review]
toolkit (v3)

Didn't look too close at the build config bits but looks ok in general
Attachment #474563 - Flags: feedback?(dtownsend) → feedback+
Comment on attachment 474563 [details] [diff] [review]
toolkit (v3)

I didn't look at it too closely because it should be mostly mechanical changes.  You were on a roll for the first part of the diff with the tab killing, please make sure that any line you touch is tab-less.
Attachment #474563 - Flags: review?(khuey) → review+
I was going to say ask the toolkit owner for approval but it seems he's ok with it ;-)
Attached patch toolkit (v4)Splinter Review
Attachment #474563 - Attachment is obsolete: true
Attachment #475548 - Flags: review?(khuey)
Comment on attachment 475548 [details] [diff] [review]
toolkit (v4)

Carrying forward r+.
Attachment #475548 - Flags: review?(khuey) → review+
Depends on: 644139
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.