595582 - Legend and more... should open on click, not mouseover

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Phil Ringnalda (:philor)]

Roughly 300 times a day, I move my mouse over the area in the upper left third of a tbpl page, while heading for one of the three tabs up there, or a bookmark, or the menu. Of those 300 times a day when the legend opens, I want to see it 0 times, and I'm distracted by something flickering in and out of existence 300 times.

more... isn't quite as bad because it has a smaller mouseover target, but it should also switch to a click target (or, infinitely better, into an actual accessible link, with a click handler), with a dropmarker to indicate that it's a menu.

Comment 1

[Arpad Borsos [:Swatinem]]

Attachment: patch

-        "<a href='" + (i == 0 ? "./" : "?tree=" + tree) + "'>" + tree + "</a>";
+        "<a href='?tree=" + tree + "'>" + tree + "</a>";

So it does not take me to the directory index when I’m working on file://

+      // oh god, I do hate event handling sometimes. I don’t get a single
+      // mouseout with target == .dropdown, instead I get a lot of mouseouts
+      // with target == ul or h2.

Maybe you can tell me why dom events just brainf*cked me again?

Comment 2

[Geoff Lankow (:darktrojan)]

Wouldn't it make more sense if it was click-to-open/click-to-close instead of click-to-open/mouseout-to-close?

Comment 3

[Arpad Borsos [:Swatinem]]

(In reply to comment #2)
> Wouldn't it make more sense if it was click-to-open/click-to-close instead of
> click-to-open/mouseout-to-close?

It is both. I personally feel mouseout-to-close is good because it requires less interaction when you just want to take a short peek at the sheriff for example.

Comment 4

[Markus Stange [:mstange]]

Attachment: only close onmousedown

I think we should only close when clicking outside the dropdown. The only differences between this patch and yours is the stuff inside UserInterface.init.

Comment 5

[Arpad Borsos [:Swatinem]]

Comment on attachment 478291 [details] [diff] [review]
only close onmousedown

>+    $("html").bind("mousedown", function clickAnywhere(e) {

We have another function called clickAnywhere, which is used to close the details pane on the bottom. Would be good to combine those two in a followup.

Comment 6

[Markus Stange [:mstange]]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/feebee7fd2de