Closed
Bug 595608
Opened 14 years ago
Closed 14 years ago
"ASSERTION: wrong type" with <svg:set> and invalid "type" attribute (nsSVGTransformSMILAttr::ValueFromString)
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: jruderman, Assigned: longsonr)
References
Details
(Keywords: assertion, testcase)
Attachments
(3 files, 1 obsolete file)
108 bytes,
image/svg+xml
|
Details | |
2.29 KB,
text/plain
|
Details | |
2.15 KB,
patch
|
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•14 years ago
|
||
Reporter | ||
Comment 2•14 years ago
|
||
###!!! ASSERTION: wrong type: 'Type() == eAtom', file content/base/src/nsAttrValue.h, line 396
Assignee | ||
Comment 3•14 years ago
|
||
Assignee: nobody → longsonr
Attachment #478050 -
Flags: review?(dholbert)
Comment 4•14 years ago
|
||
Comment on attachment 478050 [details] [diff] [review]
patch
r=dholbert if you add a comment above this line...
>+ if (typeAttr->Type() != nsAttrValue::eAtom) {
... saying something like this:
// Recognized values of |type| are parsed as an atom -- so if we have
// something other than an atom, then it means our |type| was invalid.
// (see nsSVGAnimateTransformElement::ParseAttribute)and include the test as a crashtest.
I'd be happy to land this for your (when the tree reopens to non-b7-blockers), particularly if you post the updated version with with author & commit message set, so I can just |hg import| and push. :)
Attachment #478050 -
Flags: review?(dholbert) → review+
Updated•14 years ago
|
Blocks: 468996
OS: Mac OS X → All
Hardware: x86 → All
Summary: "ASSERTION: wrong type" with <svg:set> (nsSVGTransformSMILAttr::ValueFromString) → "ASSERTION: wrong type" with <svg:set> and invalid "type" attribute (nsSVGTransformSMILAttr::ValueFromString)
Updated•14 years ago
|
blocking2.0: --- → ?
Comment 5•14 years ago
|
||
(In reply to comment #4)
> // (see nsSVGAnimateTransformElement::ParseAttribute)and include the test as
> a crashtest.
Sorry.. I could've sworn I had a newline after the ")" in ")and" there.
Assignee | ||
Comment 6•14 years ago
|
||
Attachment #478050 -
Attachment is obsolete: true
Assignee | ||
Comment 7•14 years ago
|
||
I've added the comment or at least the first two lines of it which is the best bit. I've also added the crashtest.
I've never got mq to work which is clearly my fault so this is still just a patch rather than the funky mq thing you really wanted. Sorry.
Assignee | ||
Updated•14 years ago
|
Attachment #478072 -
Flags: approval2.0?
Comment 8•14 years ago
|
||
Ah, no worries. :)
FWIW, you can generate |hg import|-able patches pretty easily without Mq, by doing:
> [make edits, or directly apply a patch]
> hg commit # type your commit message in editor when prompted
> hg export tip > patch_with_headers.txt
This outputs a patch with (a) you set as the author, and (b) your commit message already included.
No need to do that here -- I'm just mentioning it for future reference, so that you can generate "funky" :) patches without using Mq.
(It's well worth investing time to get Mq working, thouygh, IMHO -- it makes life so much better, particularly if you take it to the extreme and version-control the patches themselves! :))
Comment 9•14 years ago
|
||
(In reply to comment #8)
> > [make edits, or directly apply a patch]
> > hg commit # type your commit message in editor when prompted
> > hg export tip > patch_with_headers.txt
...and to keep your repo clean, you probably would want to follow that with:
> hg rollback
OR
> hg strip tip
either of which will remove the (outgoing) changeset from your repository.
Attachment #478072 -
Flags: approval2.0? → approval2.0+
blocking2.0: ? → final+
Whiteboard: [needs landing]
Comment 10•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b8
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•