Closed Bug 595633 Opened 14 years ago Closed 14 years ago

xpcshell: test_clearHistory_shutdown.js fails due to "ReferenceError: TOPIC_GLOBAL_SHUTDOWN is not defined", after bug 580892

Categories

(SeaMonkey :: Bookmarks & History, defect)

Product:
SeaMonkey
Component:
Bookmarks & History
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
seamonkey2.1b1

People

(Reporter: sgautherie, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Keywords: regression, Whiteboard: [Fixed by bug 588651])

http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey&maxdate=1283906242&hours=24&legend=0&norules=1 Timeframes: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3db393b691be&tochange=232553f741a0 (2 unrelated changesets) http://hg.mozilla.org/comm-central/pushloghtml?fromchange=7fbe67b91630&tochange=3a5ccff4af38 then, iiuc, bug 593855 fixed 15+ failures and "revealed" this one :-> http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1283882467.1283884174.21569.gz Linux comm-central-trunk debug test xpcshell on 2010/09/07 11:01:07 { TEST-UNEXPECTED-FAIL | .../test_clearHistory_shutdown.js | test failed (with xpcshell return code: 3), see following log: TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | ReferenceError: TOPIC_GLOBAL_SHUTDOWN is not defined - See following stack: JS frame :: /builds/slave/comm-central-trunk-linux-debug-unittest-xpcshell/build/xpcshell/tests/test_suite_places/unit/test_clearHistory_shutdown.js :: run_test :: line 113 ... /builds/slave/comm-central-trunk-linux-debug-unittest-xpcshell/build/xpcshell/head.js:181: TypeError: parts is null } http://mxr.mozilla.org/comm-central/search?string=TOPIC_GLOBAL_SHUTDOWN&case=on Indeed, TOPIC_GLOBAL_SHUTDOWN is not defined anywhere anymore :-/ Bug 580892 removed it: we need to port http://hg.mozilla.org/mozilla-central/rev/7557b96e9e02
blocking-seamonkey2.1: --- → ?
Hum, it looks like this will probably end up at a bug 588651 duplicate :-/
Depends on: 588651
Yes, this test has a few changes to port, I'm not yet certain if we need other Front End changes ported on our end though.
V.Fixed, after bug 588651 check-in, per http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1284862361.1284863937.13126.gz Linux comm-central-trunk debug test xpcshell on 2010/09/18 19:12:41
Status: NEW → RESOLVED
blocking-seamonkey2.1: ? → ---
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [Fixed by bug 588651]
Target Milestone: --- → seamonkey2.1b1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.