Double right-clicking on the title bar randomly performs actions (focusing areas, opening the bookmark sidebar, etc.)

RESOLVED FIXED in Firefox 4.0b7

Status

()

--
major
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: u88484, Assigned: Felipe)

Tracking

({dataloss, regression})

Trunk
Firefox 4.0b7
dataloss, regression
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Double right-clicking on the title bar randomly performs actions (focusing areas, opening the bookmark sidebar, etc.)  No errors in the error console.

This was confirmed by two other users on mozillazine.
(Reporter)

Updated

8 years ago
blocking2.0: --- → ?
(Reporter)

Comment 1

8 years ago
Adding dataloss because I just had my current page change to about:home
Keywords: dataloss
What OS? Aero on/off? Accelerated Layers on/off?

Comment 3

8 years ago
(In reply to comment #2)
> What OS? Aero on/off? Accelerated Layers on/off?

Windows XP Pro. Accelerated Layers on.

Comment 4

8 years ago
(In reply to comment #3)
> (In reply to comment #2)
> > What OS? Aero on/off? Accelerated Layers on/off?
> 
> Windows XP Pro. Accelerated Layers on.

Just tried it with Accelerated Layers off, the bug is still there.

Comment 5

8 years ago
Mozilla/5.0 (Windows NT 6.0; WOW64; rv:2.0b5) Gecko/20100101 Firefox/4.0b5

With menu bar disabled - for me I get the following: double right clicking in various locations to the right of the orange Firefox button refreshes page, opens the sidebar, closes the sidebar, highlights text in the searchbar, opens home page in current tab.

Windows Vista, Service Pack 2, 64-bit
Jimm, can you reproduce this and diagnose? Or Felipe?
blocking2.0: ? → betaN+
Component: General → Shell Integration
QA Contact: general → shell.integration
(Assignee)

Updated

8 years ago
Assignee: nobody → felipc
Status: NEW → ASSIGNED
Keywords: regressionwindow-wanted
(Assignee)

Comment 7

8 years ago
Created attachment 477408 [details] [diff] [review]
Patch

that was a freaky bug!

WM_NCRBUTTONDBLCLK falls through WM_APPCOMMAND
Attachment #477408 - Flags: review?(jmathies)

Updated

8 years ago
Attachment #477408 - Flags: review?(jmathies) → review+
This seems like it should get some test love...
Flags: in-testsuite?
(Assignee)

Updated

8 years ago
Whiteboard: [needs landing]
(Assignee)

Comment 9

8 years ago
(In reply to comment #8)
> This seems like it should get some test love...

This was a problem in the native event processing so a mochitest won't be able to cover it. Maybe we could include a litmus test. (although I don't think it's necessary as it'd be hard to regress this, and the bug is not 100% reproducible -- depends on the X/Y position of the click)
(In reply to comment #9)
> This was a problem in the native event processing so a mochitest won't be able
> to cover it.

That kinda sucks. Is there no way to send a native mouse event to the titlebar and synthesize the right-click?

> Maybe we could include a litmus test. (although I don't think it's
> necessary as it'd be hard to regress this, and the bug is not 100% reproducible
> -- depends on the X/Y position of the click)

It's these type of hard to notice, corner cases that need to be auto-guarded IMHO.
(Assignee)

Comment 11

8 years ago
Fixed by changeset http://hg.mozilla.org/mozilla-central/rev/0eb96c685fed
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite? → in-testsuite-
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → Firefox 4.0b8

Updated

8 years ago
Target Milestone: Firefox 4.0b8 → Firefox 4.0b7
You need to log in before you can comment on or make changes to this bug.