595652 - fix hit testing for border-radius

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We should fix hit testing so that clicking in the area clipped off by border-radius doesn't count as clicking on an element.  The places we need to fix are commented as FIXMEs in http://hg.mozilla.org/mozilla-central/rev/6e3abe4d1d2d

Comment 1

[Tantek Çelik]

additional tests include :hover triggering, and CSS cursor property rendering.  Once this is fixed, I'd like to specify this detail in CSS3-UI.

http://dev.w3.org/csswg/css3-ui/#cursor

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: simple test for :hover and 'cursor'

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch [Checked in: See comment 11]

Actually, I hit one of my assertions.  This makes a tiny tweak to avoid it; it disables the checking in nsDisplayBackground when mIsThemed is true.  I think that is probably the right thing to do as well, since border-radius really doesn't have an effect on the curvature when mIsThemed is true.

(I hit the assertion because nsDisplayBackground overrides GetBounds for the mIsThemed case, so HitTest can be called for points outside the frame's rect.)

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 478131 [details] [diff] [review]
patch
[Checked in: See comment 11]

+      // Note that we have to check !mIsThemed here to avoid triggering
+      // the assertion in RoundedBorderIntersectsRect, since when
+      // mIsThemed, our bounds can be different from the frame bounds.

Fix indent.

Shouldn't ComputeBorderRadii return zero radii for themed elements?

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: report zero border radius when themed [Checked in: Comment 7]

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Landed patch 1, but still working on test failures for patch 2 (a bunch more appeared on the Mac recently, probably due to theme changes):
http://hg.mozilla.org/mozilla-central/rev/e82310ad2cba

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(I should probably have had "1" and "2" the other way around in the previous comment.)

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: test fixes, part 1 (add new method) [Checked in: Comment 11]

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: test fixes, part 2 (send clicks to middle) [Checked in: Comment 11]

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Landed remaining patches (theme patch landed earlier; see comment 7):
http://hg.mozilla.org/mozilla-central/rev/8731e64120ab
http://hg.mozilla.org/mozilla-central/rev/12bbf60c4d97
http://hg.mozilla.org/mozilla-central/rev/5631c996d14d