Always generate PNG images for charts

RESOLVED FIXED in Bugzilla 4.2

Status

()

--
enhancement
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: LpSolit, Assigned: LpSolit)

Tracking

Bugzilla 4.2
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
The current code in reports.cgi does this check:

    my $type = $testimg->can('gif') ? "gif" : "png";

IMO, there is no reason to generate GIF images anymore, and we should always produce PNG images instead.

Gerv, are you fine with this change?
Yep, no problem.

Gerv
(Assignee)

Comment 2

8 years ago
Created attachment 482826 [details] [diff] [review]
patch, v1

I also cleaned up the list of contributors a bit, to match what we do in all other files. Granting myself review as I can now clean up charts and series code without asking for review.
Assignee: charting → LpSolit
Status: NEW → ASSIGNED
Attachment #482826 - Flags: review+
(Assignee)

Comment 3

8 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified reports.cgi
Committed revision 7529.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: approval+
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 4.2
You need to log in before you can comment on or make changes to this bug.