Closed Bug 595697 Opened 14 years ago Closed 14 years ago

"nsIPluginInstance.h(30) : warning C4099: 'gfxASurface' : type name first seen using 'class' now seen using 'struct'"

Categories

(Core Graveyard :: Plug-ins, defect)

x86
Windows 2000
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: sgautherie, Assigned: romaxa)

References

Details

Attachments

(1 file)

(I hadn't tried to build locally for a long time...)

{
...\dist\include\nsIPluginInstance.h(30) : warning C4099: 'gfxASurface' : type name first seen using 'class' now seen using 'struct'
        ...\dist\include\gfxASurface.h(56) : see declaration of 'gfxASurface'
}

http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxASurface.h
56 class THEBES_API gfxASurface {

http://mxr.mozilla.org/mozilla-central/source/modules/plugin/base/public/nsIPluginInstance.idl
50 struct gfxASurface;
Severity: blocker → minor
should we declare gfxASurface as class or something?
Yes.  This is one of MSVC's completely useless warnings.
Attached patch Trivial fixSplinter Review
Assignee: nobody → romaxa
Attachment #485123 - Flags: review?(benjamin)
Attachment #485123 - Flags: review?(benjamin) → review+
Comment on attachment 485123 [details] [diff] [review]
Trivial fix

Can someone push it or just give approval?
Attachment #485123 - Flags: approval2.0?
Attachment #485123 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/d139327473b3
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Target Milestone: --- → mozilla2.0b8
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: