595725 - Firefox: popup is null

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Sigh, we should check if there is a popup. I got rid of my all-tabs thing from the toolbar, and so we get an error at startup (and every window presumably)...

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-syncui.js#80

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Trivial, but we should fix it before we ship 4.0.

Comment 2

[Mike Connor [:mconnor]]

Blocking final, this isn't just an error, it also suppresses the updateUI call.

Comment 3

[Richard Newman [:rnewman]]

Attachment: Check for undefined popup. v1

Here's a patch...

Comment 4

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/mozilla-central/rev/e39c673699fa

(Sorry Richard, I got confused and committed this as Paul... I wish you would include the user info in your patches :)).

Comment 5

[LegNeato]

As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)