Closed Bug 595725 Opened 9 years ago Closed 9 years ago

Firefox: popup is null

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: zpao, Assigned: rnewman)

Details

(Whiteboard: [has patch][has reviews])

Attachments

(1 file)

Sigh, we should check if there is a popup. I got rid of my all-tabs thing from the toolbar, and so we get an error at startup (and every window presumably)...

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-syncui.js#80
Trivial, but we should fix it before we ship 4.0.
blocking2.0: --- → ?
Hardware: x86 → All
Blocking final, this isn't just an error, it also suppresses the updateUI call.
blocking2.0: ? → final+
blocking2.0: final+ → beta9+
Here's a patch...
Assignee: nobody → rnewman
Whiteboard: [has patch][has reviews]
https://hg.mozilla.org/mozilla-central/rev/e39c673699fa

(Sorry Richard, I got confused and committed this as Paul... I wish you would include the user info in your patches :)).
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)
No longer blocks: 615950
blocking2.0: beta9+ → betaN+
Blocks: 615950
No longer blocks: 615950
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.