Closed
Bug 595744
Opened 14 years ago
Closed 14 years ago
Remove "Check for Updates Automatically" menuitem
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla2.0b7
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | betaN+ |
People
(Reporter: Unfocused, Assigned: pcwalton)
Details
(Whiteboard: [strings][AOMTestday][in-litmus-bug-week])
Attachments
(1 file)
|
10.04 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
In the utilities dropdown menu, the The "Check for Updates Automatically" menuitem duplicates an existing checkbox in the main options dialog (Advanced -> Update -> Automatically check for updates to -> Add-ons). The menuitem in the utilities dropdown menu should be removed, to avoid cluttering that menu with unnecessary items.
|
||
Updated•14 years ago
|
Whiteboard: [good first bug]
|
Reporter | |
Updated•14 years ago
|
blocking2.0: --- → ?
|
||
Comment 1•14 years ago
|
||
This is confusing (and simple to fix) so we should get it done before the beta. Vaguely [strings]y
blocking2.0: ? → beta6+
Whiteboard: [good first bug] → [good first bug][strings]
The two global settings (autocheck & autoinstall) clearly belong together. Example: the Update tab has both for Fx updates. Why would you split them for add-on updates, with autocheck in the updates tab and autoinstall in the add-on manager? I would suggest putting both in the Update tab. Keeping both in the add-on manager is the next best thing, but splitting them up is the worst alternative.
|
||
Comment 3•14 years ago
|
||
Removals generally don't hurt us for string freezes - I think this can be a post-freeze blocker?
|
Assignee | |
Updated•14 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 4•14 years ago
|
||
I agree; would be nicer to have before we ship, but not essential.
blocking2.0: beta6+ → beta7+
|
||
Comment 6•14 years ago
|
||
ack.
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → pwalton
|
|
Assignee | |
Comment 7•14 years ago
|
||
Proposed patch attached.
Attachment #475159 -
Flags: review?(dtownsend)
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [good first bug][strings] → [strings]
|
||
Comment 8•14 years ago
|
||
Could this removal have any effect on the control sizes?
|
|
||
Comment 9•14 years ago
|
||
(In reply to comment #8)
> Could this removal have any effect on the control sizes?
It is in a popup menu and it can effect the width of it, but not I think in a way that would cause problems for localisers.
|
|
||
Comment 10•14 years ago
|
||
(In reply to comment #9)
> (In reply to comment #8)
> > Could this removal have any effect on the control sizes?
>
> It is in a popup menu and it can effect the width of it, but not I think in a
> way that would cause problems for localisers.
That should be safe.
|
|
Reporter | |
Comment 11•14 years ago
|
||
Note that this will also fix bug 583668, since that test is being removed.
|
|
||
Updated•14 years ago
|
Attachment #475159 -
Flags: review?(dtownsend) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
||
Comment 12•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7
|
||
Comment 13•14 years ago
|
||
Verified fixed
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20100916
Firefox/4.0b7pre
Status: RESOLVED → VERIFIED
|
|
||
Updated•14 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
Whiteboard: [strings] → [strings][AOMTestday][in-litmus-bug-week]
You need to log in
before you can comment on or make changes to this bug.
Description
•