595744 - Remove "Check for Updates Automatically" menuitem

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

In the utilities dropdown menu, the The "Check for Updates Automatically" menuitem duplicates an existing checkbox in the main options dialog (Advanced -> Update -> Automatically check for updates to -> Add-ons). The menuitem in the utilities dropdown menu should be removed, to avoid cluttering that menu with unnecessary items.

Comment 1

[Dave Townsend [:mossop]]

This is confusing (and simple to fix) so we should get it done before the beta. Vaguely [strings]y

Comment 2

[al_9x]

The two global settings (autocheck & autoinstall) clearly belong together.  Example: the Update tab has both for Fx updates.  Why would you split them for add-on updates, with autocheck in the updates tab and autoinstall in the add-on manager?  I would suggest putting both in the Update tab.  Keeping both in the add-on manager is the next best thing, but splitting them up is the worst alternative.

Comment 3

[Johnathan Nightingale [:johnath]]

Removals generally don't hurt us for string freezes - I think this can be a post-freeze blocker?

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

I agree; would be nicer to have before we ship, but not essential.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

errr, betaN!

Comment 6

[Axel Hecht [:Pike]]

ack.

Comment 7

[Patrick Walton (:pcwalton)]

Attachment: Proposed patch.

Proposed patch attached.

Comment 8

[(no longer active)]

Could this removal have any effect on the control sizes?

Comment 9

[Dave Townsend [:mossop]]

(In reply to comment #8)
> Could this removal have any effect on the control sizes?

It is in a popup menu and it can effect the width of it, but not I think in a way that would cause problems for localisers.

Comment 10

[(no longer active)]

(In reply to comment #9)
> (In reply to comment #8)
> > Could this removal have any effect on the control sizes?
> 
> It is in a popup menu and it can effect the width of it, but not I think in a
> way that would cause problems for localisers.

That should be safe.

Comment 11

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Note that this will also fix bug 583668, since that test is being removed.

Comment 12

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/01d08dd3a618

Comment 13

[u88484]

Verified fixed

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20100916
Firefox/4.0b7pre