Closed Bug 595744 Opened 10 years ago Closed 10 years ago

Remove "Check for Updates Automatically" menuitem

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla2.0b7
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: Unfocused, Assigned: pcwalton)

Details

(Whiteboard: [strings][AOMTestday][in-litmus-bug-week])

Attachments

(1 file)

In the utilities dropdown menu, the The "Check for Updates Automatically" menuitem duplicates an existing checkbox in the main options dialog (Advanced -> Update -> Automatically check for updates to -> Add-ons). The menuitem in the utilities dropdown menu should be removed, to avoid cluttering that menu with unnecessary items.
Whiteboard: [good first bug]
blocking2.0: --- → ?
This is confusing (and simple to fix) so we should get it done before the beta. Vaguely [strings]y
blocking2.0: ? → beta6+
Whiteboard: [good first bug] → [good first bug][strings]
The two global settings (autocheck & autoinstall) clearly belong together.  Example: the Update tab has both for Fx updates.  Why would you split them for add-on updates, with autocheck in the updates tab and autoinstall in the add-on manager?  I would suggest putting both in the Update tab.  Keeping both in the add-on manager is the next best thing, but splitting them up is the worst alternative.
Removals generally don't hurt us for string freezes - I think this can be a post-freeze blocker?
Status: NEW → ASSIGNED
I agree; would be nicer to have before we ship, but not essential.
blocking2.0: beta6+ → beta7+
errr, betaN!
blocking2.0: beta7+ → betaN+
ack.
Assignee: nobody → pwalton
Attached patch Proposed patch.Splinter Review
Proposed patch attached.
Attachment #475159 - Flags: review?(dtownsend)
Whiteboard: [good first bug][strings] → [strings]
Could this removal have any effect on the control sizes?
(In reply to comment #8)
> Could this removal have any effect on the control sizes?

It is in a popup menu and it can effect the width of it, but not I think in a way that would cause problems for localisers.
(In reply to comment #9)
> (In reply to comment #8)
> > Could this removal have any effect on the control sizes?
> 
> It is in a popup menu and it can effect the width of it, but not I think in a
> way that would cause problems for localisers.

That should be safe.
Note that this will also fix bug 583668, since that test is being removed.
Attachment #475159 - Flags: review?(dtownsend) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/01d08dd3a618
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7
Verified fixed

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20100916
Firefox/4.0b7pre
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
Flags: in-litmus-
Whiteboard: [strings] → [strings][AOMTestday][in-litmus-bug-week]
You need to log in before you can comment on or make changes to this bug.