595813 - Add L20n bindings to XBL

Status: RESOLVED INCOMPLETE

(Core :: XBL, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

XBL's XUL should be localizable via L20n.

The suggested approach is to hook it via content sink.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch v1

The code here is very similar to the code used in bug 566906. The main difference is that I had to extend XBLContentSink to provide HandleProcessingInstruction method and I have to use my own context since I cannot get it from the document.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: stop the leak attempt

Since it seems that I'm leaking here (and not in XUL content-sink case) the suspected leaker is the runtime.

Pike suggested taking runtime from the runtime service and the given patch is an attempt to do so. (it works against beta4 on top of that patch).

Unfortunately, the suggested fix causes side effect in form of such warnings on shutdown:

JS API usage error: found live context at 0x121e8b300
JS API usage error: found live context at 0x121ec9d50
JS API usage error: found live context at 0x121f0a120
JS API usage error: found live context at 0x121f7ba40
JS API usage error: 4 contexts left in runtime upon JS_DestroyRuntime.


--

Any attempt to add JS_DestroyContext in XBLContentSink destructor result in a crash. Need help!

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 474691 [details] [diff] [review]
patch v1

Comments again here, too ;-)

I would think that supporting l10n-data in xbl is a bit pointless as we don't have access to the document later to do dynamic modifications. It's a bit inconsistent though. But I guess either way.

Regarding the js context, you'll need to end up in a call to JS_DestroyContext*, not sure which api to use, though. Ask jst on that? I've searched for other call-sites, and that didn't enlighten me at all.

It'd be nice if we could factor more of the code here and in xul content sink, I guess.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch v2

patch v2, aligned with latest xul patch.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch v3

* added documentation
 * synced with XUL patch

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Seven years later, we're making another attempt to refactor our l10n layer.

The new tracking bug is bug 1365426 and I'll mark the previous effort as "INCOMPLETE".