Note: There are a few cases of duplicates in user autocompletion which are being worked on.

JSFunction::addLocal never calls Shape::maybeHash

RESOLVED FIXED in mozilla2.0b6

Status

()

Core
JavaScript Engine
P1
normal
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: brendan, Assigned: brendan)

Tracking

Other Branch
mozilla2.0b6
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
This is reported at bug 591836 comment 18 (thanks, Travis). Must fix ASAP.

/be
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED
blocking2.0: --- → ?
(Assignee)

Comment 1

7 years ago
Created attachment 474958 [details] [diff] [review]
proposed fix

Hope this is clear enough -- I fixed a fencepost bug enforcing max property tree height along the way.

Shape::getChild is the future, JSObject::getChildProperty should go away with the patch for bug 593129.

/be
Attachment #474958 - Flags: review?(jorendorff)
Comment on attachment 474958 [details] [diff] [review]
proposed fix

Looks good.
Attachment #474958 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 3

7 years ago
http://hg.mozilla.org/tracemonkey/rev/3dc4daa9621b

/be
Whiteboard: fixed-in-tracemonkey
Target Milestone: mozilla2.0b7 → mozilla2.0b6
(Assignee)

Comment 4

7 years ago
http://hg.mozilla.org/mozilla-central/rev/3dc4daa9621b

/be
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Depends on: 600067

Updated

7 years ago
blocking2.0: ? → betaN+
You need to log in before you can comment on or make changes to this bug.