Closed
Bug 595918
Opened 14 years ago
Closed 14 years ago
JSFunction::addLocal never calls Shape::maybeHash
Categories
(Core :: JavaScript Engine, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla2.0b6
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | betaN+ |
People
(Reporter: brendan, Assigned: brendan)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
5.05 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
This is reported at bug 591836 comment 18 (thanks, Travis). Must fix ASAP.
/be
|
Assignee | |
Updated•14 years ago
|
Status: NEW → ASSIGNED
blocking2.0: --- → ?
|
|
Assignee | |
Comment 1•14 years ago
|
||
Hope this is clear enough -- I fixed a fencepost bug enforcing max property tree height along the way.
Shape::getChild is the future, JSObject::getChildProperty should go away with the patch for bug 593129.
/be
Attachment #474958 -
Flags: review?(jorendorff)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 474958 [details] [diff] [review]
proposed fix
Looks good.
Attachment #474958 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Whiteboard: fixed-in-tracemonkey
Target Milestone: mozilla2.0b7 → mozilla2.0b6
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
blocking2.0: ? → betaN+
You need to log in
before you can comment on or make changes to this bug.
Description
•