595973 - [Linux] Custom location & search fields style

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Michael Monreal [:micmon]]

The toolbar text entry widgets (location and search) need a custom style

* to match the new button (TODO bug #572484) and tab style
* to better handle the SGR button (broken on some GTK themes atm)
* to better handle personas (broken on GTK themes with rounded corners atm)

Comment 1

[Michael Monreal [:micmon]]

Attachment: Current identity button on linux

One more thing this should probably cover is the look of the identity button inside the location entry which should match Win/Mac: 1px white space between location entry border and button border, darker outline around the button, rounded corners.

Comment 2

[Daniel C]

(In reply to comment #0)
> * to better handle the SGR button

The what button?

Comment 3

[Daniel C]

(In reply to comment #2)
> (In reply to comment #0)
> > * to better handle the SGR button
> 
> The what button?

Ah, I guess this is Stop-Go-Reload.

Comment 4

[tymerkaev]

Attachment: patch

Comment 5

[tymerkaev]

Attachment: patch v2

Comment 6

[Marco Castelluccio [:marco]]

Could someone review this patch?

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 524428 [details] [diff] [review]
patch v2

It's not clear that we need this. Seems that only personas would somewhat benefit from this at this point.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:dao, could you have a look please?
For more information, please visit auto_nag documentation.