Open Bug 595973 Opened 11 years ago Updated 7 years ago

[Linux] Custom location & search fields style

Categories

(Firefox :: Theme, defect)

All
Linux
defect
Not set
normal

Tracking

()

ASSIGNED

People

(Reporter: micmon, Assigned: tymerkaev)

References

Details

Attachments

(1 file, 2 obsolete files)

The toolbar text entry widgets (location and search) need a custom style

* to match the new button (TODO bug #572484) and tab style
* to better handle the SGR button (broken on some GTK themes atm)
* to better handle personas (broken on GTK themes with rounded corners atm)
Blocks: 572482
Attached image Current identity button on linux (obsolete) —
One more thing this should probably cover is the look of the identity button inside the location entry which should match Win/Mac: 1px white space between location entry border and button border, darker outline around the button, rounded corners.
(In reply to comment #0)
> * to better handle the SGR button

The what button?
(In reply to comment #2)
> (In reply to comment #0)
> > * to better handle the SGR button
> 
> The what button?

Ah, I guess this is Stop-Go-Reload.
Assignee: nobody → tymerkaev
Status: NEW → ASSIGNED
Hardware: x86 → All
Summary: [Linux] Location and search entry style → [Linux] Custom location & search fields style
Attached patch patch (obsolete) — Splinter Review
Attachment #475028 - Attachment is obsolete: true
Attachment #524424 - Flags: review?(dao)
Attachment #524424 - Attachment is obsolete: true
Attachment #524424 - Flags: review?(dao)
Attached patch patch v2Splinter Review
Attachment #524428 - Flags: review?(dao)
Could someone review this patch?
Comment on attachment 524428 [details] [diff] [review]
patch v2

It's not clear that we need this. Seems that only personas would somewhat benefit from this at this point.
Attachment #524428 - Flags: review?(dao)
You need to log in before you can comment on or make changes to this bug.