Closed Bug 596128 Opened 12 years ago Closed 12 years ago

crash [@JSObject::removeProperty] navigating away from greyhound.com

Categories

(Core :: JavaScript Engine, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla2.0b6
Tracking Status
blocking2.0 --- beta7+

People

(Reporter: Gavin, Assigned: brendan)

References

Details

(Keywords: crash, Whiteboard: fixed-in-tracemonkey)

Crash Data

Attachments

(1 file, 1 obsolete file)

This looks similar to bug 595365, but I still see it on current m-c tip (revision 3f91f47a29a8). I can reproduce it in a clean profile.

STR:
1) Load http://www.greyhound.com
2) Click any link, or close the browser window
blocking2.0: --- → ?
Assignee: general → brendan
Attachment #475166 - Flags: review?(jorendorff)
Status: NEW → ASSIGNED
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
Target Milestone: --- → mozilla2.0b6
Comment on attachment 475166 [details] [diff] [review]
d'oh! I had thought the method jit used PropertyCache::fill

This is needed but not sufficient. More in a bit.

/be
Attachment #475166 - Attachment is obsolete: true
Attachment #475166 - Flags: review?(jorendorff)
Attached patch fixSplinter Review
This is a straight-up fix. I need to develop a shell test, but this should go into tm and m-c ASAP.

/be
Attachment #475410 - Flags: review?(jorendorff)
Attachment #475410 - Flags: review+
http://hg.mozilla.org/tracemonkey/rev/5a9a613aa6e3

Sorry about the inaccurate commit message!

/be
Flags: in-testsuite?
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/6dfa6a7c94e0

I will keep this bug open to do the tests.

/be
blocking2.0: ? → beta7+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
This change looks fine but I'd like to chat with a JM hacker about this code. Any volunteers?
Attachment #475410 - Flags: review?(jorendorff) → review+
Crash Signature: [@JSObject::removeProperty]
You need to log in before you can comment on or make changes to this bug.