596155 - MTF widget is using deprecated API.

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Roger WANG]

Attachment: using updated api

With Meego Touch Framework 0.20.38-1, fennec built with MTF failed to render a black browser window, with a warning of using deprecated API MSceneWindow::appear(MSceneWindow::DeletionPolicy policy).

The attached patch fixes this and make the browser window shown correctly.

Comment 1

[Roger WANG]

(In reply to comment #0)
> Created attachment 475008 [details] [diff] [review]
> using updated api
> 
> With Meego Touch Framework 0.20.38-1, fennec built with MTF failed to render a
                                            s/failed to/failed and/
> black browser window, with a warning of using deprecated API
> MSceneWindow::appear(MSceneWindow::DeletionPolicy policy).
> 
> The attached patch fixes this and make the browser window shown correctly.

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 475008 [details] [diff] [review]
using updated api

oleg is a good enough reviewer for this.

Comment 3

[Oleg Romashin (:romaxa)]

Comment on attachment 475008 [details] [diff] [review]
using updated api

Make sense:
http://apidocs.meego.com/mtf/class_m_scene_window.html#a517747ad2df965dd67098ed1133aceaf
Please use appear(QGraphicsScene) or appear(MWindow) instead.

Comment 4

[Oleg Romashin (:romaxa)]

a=npodb

Comment 5

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mozilla-central/rev/f8a74e29e55f