596177 - remove commented-out line in webConsole.css

Status: RESOLVED WORKSFORME

(DevTools :: Console, defect)

Description

[Michael Lefevre]

The fix for bug 588014 left a line of CSS commented out which should have been removed (as requested in review in bug 588014 comment 12).

http://hg.mozilla.org/mozilla-central/file/7654e8418f86/toolkit/themes/winstripe/global/webConsole.css#l103

Comment 1

[Rob Campbell [:rc] (:robcee)]

what? No patch attached?

Comment 2

[Michael Lefevre]

I thought about it, but I don't have the tools to create a patch that would just apply, and if someone has to spend more than 30 seconds on it, they could have made their own patch in the same time... :)

Comment 3

[Rob Campbell [:rc] (:robcee)]

no problem. We'll roll this in with a fix the next time we touch the file. Thanks for reporting it!

Comment 4

[Kevin Dangoor]

Removing blocks 588014 (this bug does not actually block that other bug from going in, and was showing up in dependency-based reports...)

Comment 5

[Michael Lefevre]

No problem (especially given the trivial nature of this bug), but I thought it was a usual convention in bugzilla.m.o to mark fixed bugs as blocked by regressions from those fixes (not that doing that makes sense logically).

Comment 6

[Kevin Dangoor]

To be honest, it's entirely possible that you're correct about usual convention. It could make sense for a follow-on bug to depend on the original but not to block the original, which doesn't sound logical as you point out.

I'm still learning the b.m.o conventions and figuring out how to do things in a way that helps me manage my workload...

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Convention is for regressions to block the bug that caused them. It's somewhat arbitrary, but it makes sense if you think of it as "fixing the regresssion blocks landing the original bug on a branch".

Comment 8

[Ekanan Ketunuti]

(In reply to Michael Lefevre from comment #0)
> The fix for bug 588014 left a line of CSS commented out which should have
> been removed (as requested in review in bug 588014 comment 12).
> 
> http://hg.mozilla.org/mozilla-central/file/7654e8418f86/toolkit/themes/
> winstripe/global/webConsole.css#l103


removed https://hg.mozilla.org/mozilla-central/rev/57251#l3.79

no commented-out line of code in browser/themes/winstripe/devtools/webconsole.css