596178 - [Linux] Integrate new glyphs for tabs toolbar

Status: RESOLVED INCOMPLETE

(Firefox :: Theme, defect)

Description

[Michael Monreal [:micmon]]

Attachment: Screenshot (dark persona)

We should consider a custom style for the tab close button. The unobtrusive "x" used in the mockups seems to work very well.

The main reason why we should not keep the current look:

* the GTK button shown on hover does not work well on personas (esp. dark ones together with a bright GTK theme)
* simply not drawing the button look would mean no hover state

Comment 1

[Andreas Nilsson (:andreasn)]

I like this idea!
Simple and in the same color as the font would probably work best.

I think there are at least two options we could consider for that:
* Use a svg and have it pick up the text color (I think that still blocks on bug 231179)
* Use a custom character, such as ✕ (U+2715) [1]

1. http://www.actsofvolition.com/archive/2009/july/theemperorsnew

Comment 2

[Michael Monreal [:micmon]]

Using a font sounds interesting. But what about hover and pressed states?

SVGs could use the same trick as [1] to set the color I think? But we run into the same problem with hover and pressed states which need to work nicely on all kinds of themes. What about this:

* normal: only a simple "x" (font or svg)
* hover: add a simple border, similar to the new toolbar buttons
* pressed: darken background, similar to the new toolbar buttons

[1] http://www.stephenhorlander.com/pages/linux-svg-glyphs/linux-svg-glyphs.xhtml

Comment 3

[Andreas Nilsson (:andreasn)]

Looking closer, it seems svg's for list-style-image is possible as bug 276431 is fixed!

Comment 4

[Michael Monreal [:micmon]]

Find bar and sidebar close buttons are potential candidates for the same fix. Do we want a sparate bug for this?

Comment 5

[Michael Monreal [:micmon]]

No longer relevant with Photon theme.