Closed Bug 596295 Opened 9 years ago Closed 8 years ago

Removing call_trace workaround (added for bug 592352) leaks

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9
Tracking Status
blocking2.0 --- -
status2.0 --- wanted

People

(Reporter: bent.mozilla, Assigned: peterv)

References

Details

Attachments

(1 file)

Bug 592352 was noticed when removing a call_trace hack in jsfun.cpp. Now that IndexedDB has been fixed other things are leaking, see bug 592352 comment 22. This bug will be about fixing the remaining leak and hopefully removing the workaround.
I'm not sure what this bug is, but it looks like it's about removing a workaround. It doesn't sound critical for release. Correct me if I'm wrong.
blocking2.0: betaN+ → -
status2.0: --- → wanted
Ben, please clarify what this is about. Do we have a leak right now, or do we get a leak if we remove the workaround? Assuming we don't leak right now I'm marking this blocking-, but please renominate if this is a current leak.
Peter: do you think any of your cycle collector work will obviate the call_trace hack?  We were just running into and scratching our heads with incremental GC work.
Yes, I'm pretty sure I can land this soon together with the ClearScope removal.
\o/
Attached patch v1Splinter Review
Attachment #556544 - Flags: review?(luke)
Comment on attachment 556544 [details] [diff] [review]
v1

Review of attachment 556544 [details] [diff] [review]:
-----------------------------------------------------------------

r++
Attachment #556544 - Flags: review?(luke) → review+
http://hg.mozilla.org/mozilla-central/rev/7670696cd700
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.