The default bug view has changed. See this FAQ.

Removing call_trace workaround (added for bug 592352) leaks

RESOLVED FIXED in mozilla9

Status

()

Core
JavaScript Engine
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Ben Turner (not reading bugmail, use the needinfo flag!), Assigned: peterv)

Tracking

Trunk
mozilla9
Points:
---

Firefox Tracking Flags

(blocking2.0 -, status2.0 wanted)

Details

Attachments

(1 attachment)

Bug 592352 was noticed when removing a call_trace hack in jsfun.cpp. Now that IndexedDB has been fixed other things are leaking, see bug 592352 comment 22. This bug will be about fixing the remaining leak and hopefully removing the workaround.
I'm not sure what this bug is, but it looks like it's about removing a workaround. It doesn't sound critical for release. Correct me if I'm wrong.
blocking2.0: betaN+ → -
status2.0: --- → wanted
Ben, please clarify what this is about. Do we have a leak right now, or do we get a leak if we remove the workaround? Assuming we don't leak right now I'm marking this blocking-, but please renominate if this is a current leak.

Comment 3

6 years ago
Peter: do you think any of your cycle collector work will obviate the call_trace hack?  We were just running into and scratching our heads with incremental GC work.
(Assignee)

Comment 4

6 years ago
Yes, I'm pretty sure I can land this soon together with the ClearScope removal.

Comment 5

6 years ago
\o/
(Assignee)

Comment 6

6 years ago
Created attachment 556544 [details] [diff] [review]
v1
Attachment #556544 - Flags: review?(luke)

Comment 7

6 years ago
Comment on attachment 556544 [details] [diff] [review]
v1

Review of attachment 556544 [details] [diff] [review]:
-----------------------------------------------------------------

r++
Attachment #556544 - Flags: review?(luke) → review+
http://hg.mozilla.org/mozilla-central/rev/7670696cd700
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.