596295 - Removing call_trace workaround (added for bug 592352) leaks

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Bug 592352 was noticed when removing a call_trace hack in jsfun.cpp. Now that IndexedDB has been fixed other things are leaking, see bug 592352 comment 22. This bug will be about fixing the remaining leak and hopefully removing the workaround.

Comment 1

[David Mandelin [:dmandelin]]

I'm not sure what this bug is, but it looks like it's about removing a workaround. It doesn't sound critical for release. Correct me if I'm wrong.

Comment 2

[Johnny Stenback (:jst)]

Ben, please clarify what this is about. Do we have a leak right now, or do we get a leak if we remove the workaround? Assuming we don't leak right now I'm marking this blocking-, but please renominate if this is a current leak.

Comment 3

[Luke Wagner [:luke]]

Peter: do you think any of your cycle collector work will obviate the call_trace hack?  We were just running into and scratching our heads with incremental GC work.

Comment 4

[Peter Van der Beken [:peterv]]

Yes, I'm pretty sure I can land this soon together with the ClearScope removal.

Comment 5

[Luke Wagner [:luke]]

\o/

Comment 6

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 7

[Luke Wagner [:luke]]

Comment on attachment 556544 [details] [diff] [review]
v1

Review of attachment 556544 [details] [diff] [review]:
-----------------------------------------------------------------

r++

Comment 8

[Ed Morley [:emorley]]

http://hg.mozilla.org/mozilla-central/rev/7670696cd700