The default bug view has changed. See this FAQ.
RESOLVED FIXED

Status

Release Engineering
Other
P2
normal
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: Pike, Assigned: catlee)

Tracking

Bug Flags:
needs-treeclosure +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
There are no Firefox builds reported to the per-locale tinderbox pages. http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n-af&hours=72 is not showing any, while http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n&hours=72 does, same for de, at least.

This blocks me from checking that we actually have successful builds for new locales on Firefox 4 Beta 7.
Looking at the admin pages for a couple of individual locales I don't think we are reporting any Firefox l10n build unto those pages.

We seem to still have that code in place for buildbot-0.8.0:
http://hg.mozilla.org/build/buildbotcustom/file/buildbot-0.8.0/misc.py#l666
and the only difference that I see with the default branch:
http://hg.mozilla.org/build/buildbotcustom/file/default/misc.py#l1189
is the from address.

The other differences I see are:
* if config['enable_l10n_onchange']:
* nomergeBuilders.extend(l10n_builders)

I see the code enabling the l10n on change:
* mozilla/config.py:BRANCHES['mozilla-central']['enable_l10n_onchange'] = True

I ain't got time as of now but I thought this info could help. I don't see at first anything that got lost when porting to 0.8.0 masters.
(Reporter)

Comment 2

7 years ago
I think this worked in post 0.8.0 era times, too. Seems like a really recent regression.

Regression range is between http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n-af&maxdate=1283015590&hours=72&legend=0&norules=1 and http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n-af&maxdate=1283274790&hours=72&legend=0&norules=1, likely post 2010/08/28.
Maybe?
* Bug 589765: Set treeStableTimer=None for l10n repack jobs. - http://hg.mozilla.org/build/buildbotcustom/rev/30499aa7f126
* Bug 559150: Don't use hard coded values for pollInterval and l10nPollInterval. - http://hg.mozilla.org/build/buildbotcustom/rev/770d99c11673

From looking at commit messages on the 0.8.0 branch.
I so wish we had a unit test for this and when the repacks don't trigger on-change as it takes long to notice.
(Reporter)

Comment 4

7 years ago
So the problem is that TinderboxMailNotifier doesn't support WithProperties for tree. No wonder if or why that regressed.
(Assignee)

Comment 5

7 years ago
Most likely got lost in the 0.8.1 upgrade.
(Assignee)

Updated

7 years ago
Assignee: nobody → catlee
Priority: -- → P2
(Assignee)

Comment 6

7 years ago
Created attachment 475639 [details] [diff] [review]
Re-import upstream's tinderbox.py
Attachment #475639 - Flags: review?(nrthomas)

Updated

7 years ago
Attachment #475639 - Flags: review?(nrthomas) → review+
(Assignee)

Updated

7 years ago
Blocks: 593081
(Assignee)

Updated

7 years ago
Flags: needs-treeclosure+
(Assignee)

Updated

7 years ago
Flags: needs-treeclosure+ → needs-treeclosure?
Landing on Monday.
Flags: needs-treeclosure? → needs-treeclosure+
These appear to be working again.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Comment on attachment 475639 [details] [diff] [review]
Re-import upstream's tinderbox.py

Landed in 69c9e45f48e3
Attachment #475639 - Flags: checked-in+
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.