Closed
Bug 596487
Opened 16 years ago
Closed 16 years ago
Re-add link to about:credits in the about window
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 4.0b7
People
(Reporter: reed, Assigned: reed)
References
Details
(Whiteboard: [strings])
Attachments
(1 file, 1 obsolete file)
|
3.88 KB,
patch
|
Gavin
:
review+
reed
:
ui-review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
Since bug 579547 removed both the in-app credits and the link to about:credits, there is no place in the application that links to anything credits related. Need to add a link somewhere to about:credits. This most likely has strings consideration.
| Assignee | ||
Updated•16 years ago
|
Comment 1•16 years ago
|
||
We can linkify the "global community" line; sorry, I omitted that in one of the design revisions.
Not a disaster, IMO, if we don't get to it in time. It's a nice easter egg for contributors, and also already linked in about: as well.
blocking2.0: ? → -
Comment 2•16 years ago
|
||
I don't think we need to link this at all in the UI. As long as typing about:credits gets you there, I think we're good. I certainly wouldn't block anything on this.
| Assignee | ||
Comment 3•16 years ago
|
||
* Add link from "global community" to about:credits
* Fix typo of "LOCALIZATION"
* Add ending slashes (cuts out an unnecessary redirect)
beltzner gave the string change ui-r+ over IRC.
Assignee: nobody → reed
Status: NEW → ASSIGNED
Attachment #475412 -
Flags: ui-review+
Attachment #475412 -
Flags: review?(gavin.sharp)
| Assignee | ||
Comment 4•16 years ago
|
||
Minor changes per gavin:
* Add localization notes for other link entities
* Rev other entities, even if not changed
Attachment #475412 -
Attachment is obsolete: true
Attachment #475423 -
Flags: ui-review+
Attachment #475423 -
Flags: review?(gavin.sharp)
Attachment #475412 -
Flags: review?(gavin.sharp)
Updated•16 years ago
|
Attachment #475423 -
Flags: review?(gavin.sharp) → review+
Updated•16 years ago
|
Attachment #475423 -
Flags: approval2.0+
| Assignee | ||
Updated•16 years ago
|
Summary: Add link to about:credits somewhere → Re-add link to about:credits in the about window
| Assignee | ||
Comment 5•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b7
Verified fixed
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20100916
Firefox/4.0b7pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•