Closed Bug 59649 Opened 24 years ago Closed 24 years ago

substring() function returns one extra character

Categories

(Core :: XSLT, defect, P3)

Product:
Core
Component:
XSLT
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9

People

(Reporter: kaspar-bugmoz, Assigned: axel)

References

(
URL
)

Details

Attachments

(1 file)

fixing StringFunctionCall::evaluate
1.90 KB, patch
Details | Diff | Splinter Review 
According to http://www.w3.org/TR/1999/REC-xpath-19991116.html#function-substring

document should return "234", it returns "2345"
confirming this one. fix in hand.
I'll attach a patch right after this, Keith, Peter, please review.

I've tested with Kaspars files as well as with functions.xml. We did bad things
in that part of the code. Like flooring sums instead of adding rounds.

Axel
Assignee: kvisco → axel
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: review

    
  
Target Milestone: --- → mozilla0.9

    
    

    
  
fix is in, r=peterv, Axel
Status: NEW → RESOLVED
Closed: 24 years ago
Keywords: review
Resolution: --- → FIXED

    
    

    
  
Verified.
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: