596542 - ThebesLayerBuffer with cross-process layers behaves badly when repainting with a non-1.0 resolution

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

During a shadow-layer transaction on the compositor side, ShadowThebes saves its old render resolution if it changes.  Then during a back/front swap operation, it sends back this old resolution along with the new back buffer (previous front buffer).  Alas, but the old resolution was never updated to match the new resolution, so on every paint (and then swap) we would send back the wrong resolution and force a buffer realloc.  The resolution-change update was also being applied after the swap, which led to one extra buffer swap on resolution changes.  The upcoming patch fixes both problems.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Repainting a thebes layer with a non-1.0 resolution shouldn't (always) force buffer reallocs

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Without this patch we're going to churn memory like nobody's business when painting with a resolution applied.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

http://hg.mozilla.org/projects/cedar/rev/0de405102662