Closed Bug 596595 Opened 11 years ago Closed 11 years ago

too aggressive search for XPCOM functions

Categories

(Add-on SDK Graveyard :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mcepl, Assigned: warner)

References

Details

Attachments

(1 file)

On start of cfx run I get this:

To use chrome authority, as in:
 /home/matej/archiv/2010/projekty/bugzilla-triage/lib/rhbzpage.js
 52> soughtLines: new RegExp("^\\s*(\\[[0-9 .]*\\])?\\s*\\(\\((EE|WW)\\)|.* [Cc]hipsets?: \\)|\\s*Backtrace")
You must enable it with something like:
  const {Cc} = require("chrome");

The particular line in the code is:

        soughtLines: new RegExp("^\\s*(\\[[0-9 .]*\\])?\\s*\\(\\((EE|WW)\\)|.* [cC]hipsets?: \\)|\\s*Backtrace")

I mean, really?
The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".
Component: Jetpack SDK → General
Product: Mozilla Labs → Add-on SDK
QA Contact: jetpack-sdk → general
Assignee: nobody → warner-bugzilla
OS: Linux → All
Priority: -- → P1
Hardware: x86_64 → All
Target Milestone: --- → 1.0
See also bug 655788 : I think the scanner should ignore Cc/Cr/Cu/etc, and only look for "Components." . That means it won't be able to suggest a precise require("chrome") line (since it won't try to figure out which exact pieces they're using), but I think that's reasonable.
Duplicate of this bug: 655788
this ought to reduce the number of false positives. Also visible in https://github.com/mozilla/addon-sdk/pull/168
Attachment #533091 - Flags: review?(rFobic)
Comment on attachment 533091 [details] [diff] [review]
make the chrome/XPCOM scanner less clever, reduce false positives

Review of attachment 533091 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #533091 - Flags: review?(rFobic) → review+
Comment on attachment 533091 [details] [diff] [review]
make the chrome/XPCOM scanner less clever, reduce false positives

Review of attachment 533091 [details] [diff] [review]:
-----------------------------------------------------------------

https://wiki.mozilla.org/User:Gilma.gamez
Landed, in https://github.com/mozilla/addon-sdk/commit/ea11d7857311dce5be7632240df1522b9d3788f0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.