596595 - too aggressive search for XPCOM functions

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Matěj Cepl]

On start of cfx run I get this:

To use chrome authority, as in:
 /home/matej/archiv/2010/projekty/bugzilla-triage/lib/rhbzpage.js
 52> soughtLines: new RegExp("^\\s*(\\[[0-9 .]*\\])?\\s*\\(\\((EE|WW)\\)|.* [Cc]hipsets?: \\)|\\s*Backtrace")
You must enable it with something like:
  const {Cc} = require("chrome");

The particular line in the code is:

        soughtLines: new RegExp("^\\s*(\\[[0-9 .]*\\])?\\s*\\(\\((EE|WW)\\)|.* [cC]hipsets?: \\)|\\s*Backtrace")

I mean, really?

Comment 1

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".

Comment 2

[Brian Warner [:warner :bwarner]]

See also bug 655788 : I think the scanner should ignore Cc/Cr/Cu/etc, and only look for "Components." . That means it won't be able to suggest a precise require("chrome") line (since it won't try to figure out which exact pieces they're using), but I think that's reasonable.

Comment 4

[Brian Warner [:warner :bwarner]]

Attachment: make the chrome/XPCOM scanner less clever, reduce false positives

this ought to reduce the number of false positives. Also visible in https://github.com/mozilla/addon-sdk/pull/168

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 533091 [details] [diff] [review]
make the chrome/XPCOM scanner less clever, reduce false positives

Review of attachment 533091 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 6

[gilma gamez lopez]

Comment on attachment 533091 [details] [diff] [review]
make the chrome/XPCOM scanner less clever, reduce false positives

Review of attachment 533091 [details] [diff] [review]:
-----------------------------------------------------------------

https://wiki.mozilla.org/User:Gilma.gamez

Comment 7

[Brian Warner [:warner :bwarner]]

Landed, in https://github.com/mozilla/addon-sdk/commit/ea11d7857311dce5be7632240df1522b9d3788f0