596612 - tabs open on synced computers should be indicated in awesomelist results

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

This is shown in this mockup:
http://www.flickr.com/photos/madhava_work/4828379991/in/set-72157624047244040/

When a user is searching in the awesomescreen, and an item in the list is a currently open tab on a remote browser, we should indicate that with an icon in the spot indicated.

The android theme mockups are a more up-to-date depiction of placement and style of this icon.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

I''ve decided to use the badge helper to do this, mostly because I was looking for a way to not slow down the awesome screen.
It could be not the best decision but I think it makes sense.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 477945 [details] [diff] [review]
Patch

I like doing this in a delayed manner, but I think we should split it out from the badge system. Can you just add a separate remote badge check and method in the binding itself? I don't think we want add-ons to mess around with this badge.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Sure.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 477959 [details] [diff] [review]
Patch

Just move the remote badge code before the generic badge code. If I had to prioritize, I would say that the remote badges should become visible first. The generic badges might be time consuming.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 477959 [details] [diff] [review]
Patch


>+#ifdef MOZ_SERVICES_SYNC
>+              // once we have check badges, check if the tab is in the remote list
>+              if (!Weave.Service.isLoggedIn)
>+                return;
>+
>+              for (let i = 0; i < remoteItems.length; i++) {
>+                let remoteURI = remoteItems[i].uri;
>+                if (remoteURI) {
>+                  let itemHost = Services.io.newURI(currentURL, null, null);
>+                  let remoteHost = Services.io.newURI(remoteURI, null, null);
>+                  if (itemHost.equals(remoteHost))
>+                    item.setAttribute("remote", "true");
>+                }

I am wondering how slow this will be. For people like me, the remoteItems array could be a few hundred items. Well need to keep an eye on this.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/8c028cdaeee7

Comment 7

[Ioana Chiorean]

https://litmus.mozilla.org/show_test.cgi?id=15195

Comment 8

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Android; Linux armv71; rv:2.0b13pre) Gecko/20110317 Firefox/4.0b13pre Fennec/4.0b6pre