Closed Bug 596649 Opened 14 years ago Closed 13 years ago

Check if a web app is installed to not install dupes

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(fennec-)

Status:
VERIFIED FIXED
Milestone:
Firefox 8
Tracking Flags:
Tracking Status
fennec - ---

People

(Reporter: fabrice, Assigned: fabrice)

References

Details

(Whiteboard: [has-patch])

Attachments

(1 file, 2 obsolete files)

updated patch
901 bytes, patch
mfinkle
: review+
Details | Diff | Splinter Review 
We  should not display the "Install App" menu item if the application is already installed.
Assignee: nobody → fabrice
Blocks: 583750
Attached patch patch (UI + maemo) (obsolete) — — Splinter Review 
Straightforward implementation for Maemo, by checking that the mozilla specific desktop file for this web app is already present in /usr/share/applications/hildon.
Attachment #475800 - Flags: review?(mark.finkle)
Attachment #475800 - Flags: review?(mark.finkle) → review+
Whiteboard: [fennec-checkin-postb1]
Flags: in-litmus?
tracking-fennec: --- → ?
Whiteboard: [fennec-checkin-postb1]
tracking-fennec: ? → 2.0+
tracking-fennec: 2.0+ → 2.0b3+

        Attachment #475800 -
        Attachment is obsolete: true

        Attachment #488242 -
        Flags: review?(mark.finkle)
Whiteboard: [has-patch]

        Attachment #488242 -
        Flags: review?(mark.finkle) → review+

    
    

    
  
Moving to post fennec4
tracking-fennec: 2.0b3+ → 2.0-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        updated patch
        — 
          — Splinter Review
      

    


  

        Attachment #488242 -
        Attachment is obsolete: true

    
    

    
  
Clear to land

    
    

    
  
Merged:
http://hg.mozilla.org/mozilla-central/rev/974ed642bd37
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8

    
    

    
  
I could not reproduce this issue on the latest Nightly build. However, on the latest Aurora build I cannot see "Install App" option in the Site Panel, so I cannot verify this issue for Firefox 8. Is there more work to do about Aurora build? Or should I set the target milestone to Firefox 9 and close this bug as verified fixed?

--
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110913
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2

    
    

    
  
(In reply to Cristian Nicolae (:xti) from comment #8)
> I could not reproduce this issue on the latest Nightly build. However, on
> the latest Aurora build I cannot see "Install App" option in the Site Panel,
> so I cannot verify this issue for Firefox 8. Is there more work to do about
> Aurora build? Or should I set the target milestone to Firefox 9 and close
> this bug as verified fixed?
> 
> --
> Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110913
> Firefox/9.0a1 Fennec/9.0a1
> Device: Samsung Galaxy S
> OS: Android 2.2

No. The original implementation that landed was merely a prototype or testing example, and was removed in Aurora (http://hg.mozilla.org/releases/mozilla-aurora/rev/1b904630fdd7) via bug 684910.

    
    

    
  
This issue doesn't occur anymore on the latest Nightly build. So I will close the bug as verified fixed.

--
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110914
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: