59665 - select list's selectedIndex setter does not attempt to convert strings to numbers

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Robert Ginda]

ETrade stores your last "start in" select box value in a cookie each time you
change it.  When revisiting the site, it reads this cookie and tries to reset it
to whatever you had last.  The line where the select box state is restored is:
document.forms[0].goWhere.selectedIndex = selectGoWhere;
Where |selectGoWhere| is split out of the cookie, and never converted from a
string to a number.  The DOM glue code generated by JSStubGen doesn't attempt to
convert strings to numbers, and so this line of JS fails with an
NS_ERROR_DOM_NOT_NUMBER_ERR error.

The attached patch should fix this by allowing JS to do attempt a conversion to
an int32 if the value is a string.  If this conversion should fail,
NS_ERROR_DOM_NOT_NUMBER_ERR will then be reported.  (The same way a
JSVAL_IS_NUMBER would fail if it were outside the range of an int32, btw.)

Comment 1

[Robert Ginda]

Attachment: changes to dom/tools/JSStubGen.cpp

Comment 2

[Johnny Stenback (:jst)]

This will be fixed once the DOM uses XPConnect since XPConnect already deals
with this. We're working on this right now. Pushing this to Future to keep it
off my bug radar.

Comment 3

[Johnny Stenback (:jst)]

Fixed with the xpcdom landing.