59666 - Occurances of uninitialized variables being used before being set.

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Rich Burridge]

For more details on this problem, see:

http://bugzilla.mozilla.org/show_bug.cgi?id=59652

This bug is just for the warnings in various source files in the 
Internationization module:

nsUnicodeToISO2022JP.cpp:153: warning: `nsresult res' might be used
uninitialized in this function
----
nsCharDetModule.cpp:151: warning: `nsresult rv' might be used uninitialized in
this function
----
nsPSMDetectors.cpp:442: warning: `PRInt32 bestIdx' might be used uninitialized
in this function
----

Comment 1

[nhottanscp]

Reassign to shanjian.

Comment 2

[Shanjian Li]

Attachment: patch 1

Comment 3

[Shanjian Li]

Attachment: patch 2

Comment 4

[Shanjian Li]

Attachment: patch 3

Comment 5

[Shanjian Li]

The first 2 places seems fine. The 3rd is very likely to cause crashes. Let me 
know when and where should I check in those fixes. (Please email me directly.)

frank, please review those changes.

Comment 6

[Rich Burridge]

It's too late to check in to the RTM branch, so I'm assuming
these changes will need to be checked into the Mozilla trunk.
We (Sun) will also be adding similar changes to our OEM source
code branch for our RTM/FCS release. Thanks for finding/fixing
these so quickly!

Comment 7

[nhottanscp]

For the first patch, should it be initialized as NS_OK or an error?
Cata, do you have any idea?

Comment 8

[Shanjian Li]

The only case that res will not be assigned before it is returned by is
Src >= SrcEnd, and that is the length equal to 0. Since there is nothing 
to do, we cann't say it's a failure.

Comment 9

[nhottanscp]

Okay, r=nhotta for three patches (Frank is not available now), please get a
super review.

Comment 10

[Erik van der Poel]

Patch 3 seems to have some indentation problems. Maybe you have tabs in there?
There should not be any tabs in Mozilla source. Please fix this, and re-submit
Patch 3. Then I will give sr=.

Comment 11

[Shanjian Li]

Attachment: new patch, part3

Comment 12

[Shanjian Li]

Attachment: new patch, part 2

Comment 13

[Shanjian Li]

new patch remove tab to spaces. 

Comment 14

[Erik van der Poel]

Shanjian, the Mozilla convention is to use 2 spaces to indent.

  http://www.mozilla.org/newlayout/doc/codingconventions.html

No need to attach new patches. sr=erik as long as you change it to 2 spaces

Comment 15

[Shanjian Li]

fix checked in.

Comment 16

[Rich Burridge]

Changes also checked into the OEM branch.

Comment 17

[Teruko Kobayashi]

Changed QA contact to [e-mail].  Shanjian, QA cannot verify this.  Please mark as verified.

Comment 18

[Shanjian Li]

mark it verified.