Closed Bug 596852 Opened 12 years ago Closed 11 years ago

purge_builds should delete directories older than some threshold

Categories

(Release Engineering :: General, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: catlee, Assigned: catlee)

References

Details

Attachments

(2 files)

If purge_builds were to delete directories older than a week or so, we would
a) clean out old cruft from the /builds/slave directory
b) make it so that we're not always running as close to full as possible
Attachment #475827 - Attachment description: [untested] delete directories older than 7 days → delete directories older than 7 days
Attachment #475827 - Flags: review?(bhearsum)
Comment on attachment 475827 [details] [diff] [review]
delete directories older than 7 days

Looks good
Attachment #475827 - Flags: review?(bhearsum) → review+
Blocks: end_to_end
Assignee: nobody → catlee
OS: Linux → All
Hardware: x86_64 → All
Priority: -- → P3
This will land on Monday.
Flags: needs-reconfig+
So the summary and comments do not match the code I see here...

It seems like we _always_ preserve builds newer than 7 days, rather than always delete older than 7 days. [am I wrong]

I expected this bug to be a "We want to delete all builds older than 7 days, and/or newer builds if we still do not have the free-space we want"

Am I either missing something or wrong?
(In reply to comment #4)
> So the summary and comments do not match the code I see here...

Nope just confused.

> Am I either missing something or wrong?

Missed the addition of |dirs.sort()| before the while... sorry for noise.
This is landed and working.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 475827 [details] [diff] [review]
delete directories older than 7 days

Landed in e179cf0fd98b
Attachment #475827 - Flags: checked-in+
This got backed out because it caused windows 7 test machines to fail (because they timed out when cleaning up).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #475827 - Flags: checked-in+ → checked-in-
Flags: needs-reconfig+
Flags: needs-treeclosure?
could we include this change with a bigger threshold at first and then reduce it every week?
I believe the machines that burned the day we enabled had many many GBs of old stuff and that is why it timed out as it had too many things to remove. Think of the IX machines that barely need to clobber as their disk always have more than 12GB free and everything is just getting older.

Maybe we could ask the script to check if they have spend X amount of mins deleting stuff and then stop if they have passed it. Luckily the machine would stop between X and the buildbot timeout.
Why is this needs-treeclosure? if the patch that broke win7 hasn't been changed?
(In reply to comment #10)
> Why is this needs-treeclosure? if the patch that broke win7 hasn't been
> changed?

We expect that after the win7 slaves cycle through and clean up, that this will work ok going forward.  So it needs tree closure because we expect burning the first time stuff is getting run, but it should be ok after.
I'm also fine with Armen's suggestion of increasing the threshold.  The max_age default at line 130 needs to be changed.  I'd recommend 28 days to start with.
Comment on attachment 475827 [details] [diff] [review]
delete directories older than 7 days

Checked in with 28 day default:
http://hg.mozilla.org/build/tools/rev/7920b159c3e6
Attachment #475827 - Flags: checked-in- → checked-in+
Flags: needs-treeclosure? → needs-treeclosure+
Leaving open to crank down the threshold.
Flags: needs-treeclosure+
Attachment #486252 - Flags: review?(nrthomas)
Attachment #486252 - Flags: review?(nrthomas) → review+
Doesn't need a reconfig per se, but needs somebody to watch it for a bit.
Flags: needs-reconfig?
Comment on attachment 486252 [details] [diff] [review]
reduce max age to 14 days

changeset:   883:5a99b6e600c6
Attachment #486252 - Flags: checked-in+
Flags: needs-reconfig? → needs-reconfig+
14 days is a good number to finish with.
Status: REOPENED → RESOLVED
Closed: 12 years ago11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.