596852 - purge_builds should delete directories older than some threshold

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Chris AtLee [:catlee]]

If purge_builds were to delete directories older than a week or so, we would
a) clean out old cruft from the /builds/slave directory
b) make it so that we're not always running as close to full as possible

Comment 1

[Chris AtLee [:catlee]]

Attachment: delete directories older than 7 days

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 475827 [details] [diff] [review]
delete directories older than 7 days

Looks good

Comment 3

[[e-mail] (:bhearsum)]

This will land on Monday.

Comment 4

[Justin Wood (:Callek)]

So the summary and comments do not match the code I see here...

It seems like we _always_ preserve builds newer than 7 days, rather than always delete older than 7 days. [am I wrong]

I expected this bug to be a "We want to delete all builds older than 7 days, and/or newer builds if we still do not have the free-space we want"

Am I either missing something or wrong?

Comment 5

[Justin Wood (:Callek)]

(In reply to comment #4)
> So the summary and comments do not match the code I see here...

Nope just confused.

> Am I either missing something or wrong?

Missed the addition of |dirs.sort()| before the while... sorry for noise.

Comment 6

[[e-mail] (:bhearsum)]

This is landed and working.

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 475827 [details] [diff] [review]
delete directories older than 7 days

Landed in e179cf0fd98b

Comment 8

[[e-mail] (:bhearsum)]

This got backed out because it caused windows 7 test machines to fail (because they timed out when cleaning up).

Comment 9

[Armen [:armenzg]]

could we include this change with a bigger threshold at first and then reduce it every week?
I believe the machines that burned the day we enabled had many many GBs of old stuff and that is why it timed out as it had too many things to remove. Think of the IX machines that barely need to clobber as their disk always have more than 12GB free and everything is just getting older.

Maybe we could ask the script to check if they have spend X amount of mins deleting stuff and then stop if they have passed it. Luckily the machine would stop between X and the buildbot timeout.

Comment 10

[Aki Sasaki (not active)]

Why is this needs-treeclosure? if the patch that broke win7 hasn't been changed?

Comment 11

[Chris AtLee [:catlee]]

(In reply to comment #10)
> Why is this needs-treeclosure? if the patch that broke win7 hasn't been
> changed?

We expect that after the win7 slaves cycle through and clean up, that this will work ok going forward.  So it needs tree closure because we expect burning the first time stuff is getting run, but it should be ok after.

Comment 12

[Chris AtLee [:catlee]]

I'm also fine with Armen's suggestion of increasing the threshold.  The max_age default at line 130 needs to be changed.  I'd recommend 28 days to start with.

Comment 13

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 475827 [details] [diff] [review]
delete directories older than 7 days

Checked in with 28 day default:
http://hg.mozilla.org/build/tools/rev/7920b159c3e6

Comment 14

[Nick Thomas [:nthomas] (UTC+12)]

Leaving open to crank down the threshold.

Comment 15

[Chris AtLee [:catlee]]

Attachment: reduce max age to 14 days

Comment 16

[Chris AtLee [:catlee]]

Doesn't need a reconfig per se, but needs somebody to watch it for a bit.

Comment 17

[Chris AtLee [:catlee]]

Comment on attachment 486252 [details] [diff] [review]
reduce max age to 14 days

changeset:   883:5a99b6e600c6

Comment 18

[Chris AtLee [:catlee]]

14 days is a good number to finish with.