Closed Bug 596901 Opened 9 years ago Closed 9 years ago

"ASSERTION: Attempting to nest call to BeginSecureKeyboardInput" when iframes fight over password-field focus

Categories

(Core :: Widget, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: jaas)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase, Whiteboard: [will be fixed by bug 556873])

Attachments

(2 files)

Attached file testcase
###!!! ASSERTION: Attempting to nest call to BeginSecureKeyboardInput!: '!debug_InSecureKeyboardInputMode', file widget/src/xpwidgets/nsBaseWidget.cpp, line 966

###!!! ASSERTION: Calling EndSecureKeyboardInput when it hasn't been enabled!: 'debug_InSecureKeyboardInputMode', file widget/src/xpwidgets/nsBaseWidget.cpp, line 976
Note that the reftest for bug 542116 triggers this assertion, and the assertion annotation for that should be removed once this is fixed.
This will be fixed by bug 556873.  Basically, the current way that we call BeginSecureKeyboardInput doesn't map to EndSecureKeyboardInput calls at all.  To demonstrate:

1. Loading data:text/html,<input autofocus type=password> calls BeginSecureKeyboardInput.
2. Loading data:text/html,foo in the same tab will _not_ result in a call to EndSecureKeyboardInput.
3. Loading data:text/html,<input autofocus type=password> in the same tab again will cause another call to BeginSecureKeyboardInput, which will assert.
Depends on: 556873
Whiteboard: [will be fixed by bug 556873]
Assignee: nobody → joshmoz
Fixed by the patch in bug 556873.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.