597006 - Add-ons for your Fennec section doesn't disappear when no result

Status: VERIFIED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Ioana Chiorean]

Attachment: screenshot

Build Identifier: Mozilla/5.0 (Android; Linux armv7l; en-US; rv:2.0b7pre)
Gecko/20090916 Firefox/4.0b7pre Fennec/2.0b1pre 

Device Android Motorola Droid 2 and HTC Desire

Steps to reproduce:
1. open Fennec-> go to page about:home

Expected result:
- if no search result found, section should disappear (works on Maemo)

Actual result:
- section is displaying no recommended add-ons

Note :
Please see comment 2 from Mark Finkle in bug:591926

https://bugzilla.mozilla.org/show_bug.cgi?id=591926

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I should be more clear in my explanations:
* If the search is successful, but no add-ons are returned, we display "No recommended add-ons"
* If the search failed for network issues or server issues, we remove the entire "Add-ons for your Fennec" section.

So this behavior looks fine to me.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Code:

Show the "none found message":
http://mxr.mozilla.org/mobile-browser/source/chrome/content/aboutHome.xhtml#284

Remove the section on a failure:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/aboutHome.xhtml#326

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

verified :

Mozilla/5.0 (Android; Linux armv71; rv2.0b7pre) Gecko/20100917 Firefox/4.0b7pre Fennec/2.0b1pre