597010 - Some form elements are rendered with thick black borders on Maemo/GTK

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b6pre) Gecko/20100916 Namoroka/4.0b7pre Fennec/2.0b1pre

Steps to Reproduce:
1. Go to bugzilla.mozilla.org/

Actual Results:
The buttons and input fields on the page will be bordered black

Expected Results:
The borders of the buttons and input fields should not be black and colored however way fennec wants it to be colored.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

Screenshot shows the boxes in the middle with the issue

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Including in notes from what the screenshot was from :  

Mozilla/5.0 (Maemo;Linux armv71; rv:2.0b7pre)Gecko/20100916 Firefox/4.0b7pre Fennec/2.0b1pre

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Simple form testing with textboxes, radio buttons, checkboxes, drop down boxes show this issue:
1. goto http://people.mozilla.com/~nhirata/html_tp/formsninput.html

Comment 4

[Tony Chung [:tchung]]

Attachment: Zimbra Black borders + Button screenshot

You can also just try https://mail.mozilla.com.  attached another screen.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: Simple band-aid patch

This patch simply turns off all native theming for all widgets. It "fixes" the problem, but I'd like to know why this regressed.

Fennec uses a preference to disable native theme support. The colors and borders you see in this bug are due to native theme setting the defaults. As I mentioned, Fennec should be turning off native theme.

I only see this error in remote pages and the regression seemed to after after cedar landed on m-c. I have been looking into how puppet widgets interact with the native theme system, but I haven't found any clue of native theme in puppet widgets. I guess that might be the problem. Puppet widgets probably need to be taught about native themes and how to disable them?

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Too see this bug on desktop Lnux, just change the desktop appearance to an inverse theme. While your desktop will look like crap, you should not see any difference in Fennec.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: css changes only

The last patch had other stuff in it. This patch is all that is needed.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: stricter css fix

This patch uses an existing rule and should be better for performance.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 477108 [details] [diff] [review]
stricter css fix

Could you put a comment when landing to remind us to remove it once the cedar regression will be fixed?

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/c76cedf4ca18

filed bug 598421 for the platform fix

Comment 11

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b6pre) Gecko/20100922 Namoroka/4.0b7pre Fennec/2.0b1pre