Correct typo and adjust spacing for new Firefox compatibility UI in the HTTP preference pane

RESOLVED FIXED in seamonkey2.1b1

Status

SeaMonkey
Preferences
--
trivial
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: rsx11m, Assigned: rsx11m)

Tracking

Trunk
seamonkey2.1b1

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
(Quoting bug 591327 comment #12)
> > I'd prefer s/Announce/Advertise/g (or whatever the U.S. spelling is)
> I agree, Advertise (or Advertize) sounds better.

Intuitively (and, more importantly, per dictionary) it is "Advertise" rather than "Advertize", thus fixing this in the following patch. Apparently the rules to translate British English to American English are somewhat inconsistent in this case.

While I'm there, I'm also including a thin separator before that group to get
a bit distance from the pipelining warning, in this way making the context of that warning more obvious. The other separators in the connection options are historically thick, I've added "thin" there as well to reduce the spacing.
This should look better overall.
(Assignee)

Comment 1

7 years ago
Created attachment 475895 [details] [diff] [review]
Simple fix [Checkin: Comment 14]

Note that I didn't rename the entity names. It's a fixed typo in en-US only without any change in semantics, thus no need to bother the localizers.
Assignee: nobody → rsx11m.pub
Status: NEW → ASSIGNED
Attachment #475895 - Flags: superreview?(neil)
Attachment #475895 - Flags: review?(iann_bugzilla)
(Assignee)

Updated

7 years ago
Summary: Correct typo and spacing for new Firefox compatibility UI in the HTTP preference pane → Correct typo and adjust spacing for new Firefox compatibility UI in the HTTP preference pane
(Assignee)

Comment 2

7 years ago
Created attachment 475908 [details]
Screenshots for layout comparison

From left to right:
- current spacing
- with separator added before UA string group
- separators marked "thin" in connection groups

Comment 3

7 years ago
From all I know, the US spelling is "advertize", so there is NO typo here. Our prime locale is en-US, not en-GB. There is a separate en-GB locale for a reason.
(Assignee)

Comment 4

7 years ago
I know, that's why I looked it up. That dictionary provides the en-US version, as you can verify with "analyze" (en-US) vs. "analyse" (en-GB). Also, the en-US SeaMonkey spellcheck underlines "advertize" but not "advertise", thus I'm quite confident that the proposed change is correct.

Comment 5

7 years ago
My Langenscheidt English/German dictionary says "advertise, American also: advertize". I guess we'd need to ask American native speakers with language knowledge. I don't know if we have any of those on the SeaMonkey project.
(Assignee)

Comment 6

7 years ago
I've never seen it written "advertize", which is why it caught my attention.
Adding some people with EDT time stamps to the CC list for more opinions...

Comment 7

7 years ago
Typing "definition:advertize" into google gets:

Did you mean: definition:advertise  Top 2 results shown

advertise - definition of advertise by the Free Online Dictionary ...
v. ad·ver·tised, ad·ver·tis·ing, ad·ver·tis·es. v.tr. 1. To make public announcement of, especially to proclaim the qualities or advantages of (a product or ...
www.thefreedictionary.com/advertise - Cached - Similar

advertising: Definition, Synonyms from Answers.com
advertising n. The activity of attracting public attention to a product or business, as by paid announcements in the print, broadcast, or electronic.
www.answers.com/topic/advertising - Cached - Similar

Comment 8

7 years ago
Whatever. This is not worth fighting over, and I'm far from really knowing those details well enough. Ask some Aerican or do what the reviewers decide.
(Assignee)

Comment 9

7 years ago
Phil's first reference states "advertise sometimes US, advertize [ˈædvəˌtaɪz]" which would make it appear that "advertise" is preferred over "advertize" even if the latter form may be correct, but I'm flexible with that interpretation.

Comment 10

7 years ago
http://en.wikipedia.org/wiki/American_and_British_English_spelling_differences (not 100% obvious, but I could easily interpret it as 'advertise' is the right one)

Updated

7 years ago
Attachment #475895 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 11

7 years ago
To conclude, Stefan's Wikipedia link in comment #10 holds the key: "advertise" is not of Greek origin, thus it shouldn't be "-ize"ified in American English.

Comment 12

7 years ago
Comment on attachment 475895 [details] [diff] [review]
Simple fix [Checkin: Comment 14]

Thanks for this patch r=me :)
Attachment #475895 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 13

7 years ago
Thanks for the reviews, push on comm-central please.
Keywords: checkin-needed
Whiteboard: [c-n: comm-central]

Comment 14

7 years ago
Comment on attachment 475895 [details] [diff] [review]
Simple fix [Checkin: Comment 14]

http://hg.mozilla.org/comm-central/rev/0a06605db9b0
Attachment #475895 - Attachment description: Simple fix → Simple fix [Checkin: Comment 14]

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: comm-central]
Target Milestone: --- → seamonkey2.1b1
You need to log in before you can comment on or make changes to this bug.