Last Comment Bug 597051 - Correct typo and adjust spacing for new Firefox compatibility UI in the HTTP preference pane
: Correct typo and adjust spacing for new Firefox compatibility UI in the HTTP ...
Product: SeaMonkey
Classification: Client Software
Component: Preferences (show other bugs)
: Trunk
: All All
-- trivial (vote)
: seamonkey2.1b1
Assigned To: rsx11m
Depends on:
Blocks: 591327
  Show dependency treegraph
Reported: 2010-09-16 10:28 PDT by rsx11m
Modified: 2010-09-17 14:57 PDT (History)
6 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Simple fix [Checkin: Comment 14] (3.59 KB, patch)
2010-09-16 10:32 PDT, rsx11m
iann_bugzilla: review+
neil: superreview+
Details | Diff | Splinter Review
Screenshots for layout comparison (7.22 KB, image/png)
2010-09-16 10:58 PDT, rsx11m
no flags Details

Description User image rsx11m 2010-09-16 10:28:16 PDT
(Quoting bug 591327 comment #12)
> > I'd prefer s/Announce/Advertise/g (or whatever the U.S. spelling is)
> I agree, Advertise (or Advertize) sounds better.

Intuitively (and, more importantly, per dictionary) it is "Advertise" rather than "Advertize", thus fixing this in the following patch. Apparently the rules to translate British English to American English are somewhat inconsistent in this case.

While I'm there, I'm also including a thin separator before that group to get
a bit distance from the pipelining warning, in this way making the context of that warning more obvious. The other separators in the connection options are historically thick, I've added "thin" there as well to reduce the spacing.
This should look better overall.
Comment 1 User image rsx11m 2010-09-16 10:32:49 PDT
Created attachment 475895 [details] [diff] [review]
Simple fix [Checkin: Comment 14]

Note that I didn't rename the entity names. It's a fixed typo in en-US only without any change in semantics, thus no need to bother the localizers.
Comment 2 User image rsx11m 2010-09-16 10:58:53 PDT
Created attachment 475908 [details]
Screenshots for layout comparison

From left to right:
- current spacing
- with separator added before UA string group
- separators marked "thin" in connection groups
Comment 3 User image Robert Kaiser 2010-09-16 11:02:55 PDT
From all I know, the US spelling is "advertize", so there is NO typo here. Our prime locale is en-US, not en-GB. There is a separate en-GB locale for a reason.
Comment 4 User image rsx11m 2010-09-16 11:57:21 PDT
I know, that's why I looked it up. That dictionary provides the en-US version, as you can verify with "analyze" (en-US) vs. "analyse" (en-GB). Also, the en-US SeaMonkey spellcheck underlines "advertize" but not "advertise", thus I'm quite confident that the proposed change is correct.
Comment 5 User image Robert Kaiser 2010-09-16 12:08:07 PDT
My Langenscheidt English/German dictionary says "advertise, American also: advertize". I guess we'd need to ask American native speakers with language knowledge. I don't know if we have any of those on the SeaMonkey project.
Comment 6 User image rsx11m 2010-09-16 12:15:58 PDT
I've never seen it written "advertize", which is why it caught my attention.
Adding some people with EDT time stamps to the CC list for more opinions...
Comment 7 User image Philip Chee 2010-09-16 12:19:01 PDT
Typing "definition:advertize" into google gets:

Did you mean: definition:advertise  Top 2 results shown

advertise - definition of advertise by the Free Online Dictionary ...
v. ad·ver·tised, ad·ver·tis·ing, ad·ver·tis·es. 1. To make public announcement of, especially to proclaim the qualities or advantages of (a product or ... - Cached - Similar

advertising: Definition, Synonyms from
advertising n. The activity of attracting public attention to a product or business, as by paid announcements in the print, broadcast, or electronic. - Cached - Similar
Comment 8 User image Robert Kaiser 2010-09-16 12:26:08 PDT
Whatever. This is not worth fighting over, and I'm far from really knowing those details well enough. Ask some Aerican or do what the reviewers decide.
Comment 9 User image rsx11m 2010-09-16 12:27:48 PDT
Phil's first reference states "advertise sometimes US, advertize [ˈædvəˌtaɪz]" which would make it appear that "advertise" is preferred over "advertize" even if the latter form may be correct, but I'm flexible with that interpretation.
Comment 10 User image Stefan [:stefanh] 2010-09-16 12:40:45 PDT (not 100% obvious, but I could easily interpret it as 'advertise' is the right one)
Comment 11 User image rsx11m 2010-09-17 09:52:38 PDT
To conclude, Stefan's Wikipedia link in comment #10 holds the key: "advertise" is not of Greek origin, thus it shouldn't be "-ize"ified in American English.
Comment 12 User image Ian Neal 2010-09-17 11:03:18 PDT
Comment on attachment 475895 [details] [diff] [review]
Simple fix [Checkin: Comment 14]

Thanks for this patch r=me :)
Comment 13 User image rsx11m 2010-09-17 11:24:55 PDT
Thanks for the reviews, push on comm-central please.

Note You need to log in before you can comment on or make changes to this bug.