Closed Bug 597051 Opened 9 years ago Closed 9 years ago

Correct typo and adjust spacing for new Firefox compatibility UI in the HTTP preference pane

Categories

(SeaMonkey :: Preferences, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1b1

People

(Reporter: rsx11m.pub, Assigned: rsx11m.pub)

References

()

Details

Attachments

(2 files)

(Quoting bug 591327 comment #12)
> > I'd prefer s/Announce/Advertise/g (or whatever the U.S. spelling is)
> I agree, Advertise (or Advertize) sounds better.

Intuitively (and, more importantly, per dictionary) it is "Advertise" rather than "Advertize", thus fixing this in the following patch. Apparently the rules to translate British English to American English are somewhat inconsistent in this case.

While I'm there, I'm also including a thin separator before that group to get
a bit distance from the pipelining warning, in this way making the context of that warning more obvious. The other separators in the connection options are historically thick, I've added "thin" there as well to reduce the spacing.
This should look better overall.
Note that I didn't rename the entity names. It's a fixed typo in en-US only without any change in semantics, thus no need to bother the localizers.
Assignee: nobody → rsx11m.pub
Status: NEW → ASSIGNED
Attachment #475895 - Flags: superreview?(neil)
Attachment #475895 - Flags: review?(iann_bugzilla)
Summary: Correct typo and spacing for new Firefox compatibility UI in the HTTP preference pane → Correct typo and adjust spacing for new Firefox compatibility UI in the HTTP preference pane
From left to right:
- current spacing
- with separator added before UA string group
- separators marked "thin" in connection groups
From all I know, the US spelling is "advertize", so there is NO typo here. Our prime locale is en-US, not en-GB. There is a separate en-GB locale for a reason.
I know, that's why I looked it up. That dictionary provides the en-US version, as you can verify with "analyze" (en-US) vs. "analyse" (en-GB). Also, the en-US SeaMonkey spellcheck underlines "advertize" but not "advertise", thus I'm quite confident that the proposed change is correct.
My Langenscheidt English/German dictionary says "advertise, American also: advertize". I guess we'd need to ask American native speakers with language knowledge. I don't know if we have any of those on the SeaMonkey project.
I've never seen it written "advertize", which is why it caught my attention.
Adding some people with EDT time stamps to the CC list for more opinions...
Typing "definition:advertize" into google gets:

Did you mean: definition:advertise  Top 2 results shown

advertise - definition of advertise by the Free Online Dictionary ...
v. ad·ver·tised, ad·ver·tis·ing, ad·ver·tis·es. v.tr. 1. To make public announcement of, especially to proclaim the qualities or advantages of (a product or ...
www.thefreedictionary.com/advertise - Cached - Similar

advertising: Definition, Synonyms from Answers.com
advertising n. The activity of attracting public attention to a product or business, as by paid announcements in the print, broadcast, or electronic.
www.answers.com/topic/advertising - Cached - Similar
Whatever. This is not worth fighting over, and I'm far from really knowing those details well enough. Ask some Aerican or do what the reviewers decide.
Phil's first reference states "advertise sometimes US, advertize [ˈædvəˌtaɪz]" which would make it appear that "advertise" is preferred over "advertize" even if the latter form may be correct, but I'm flexible with that interpretation.
http://en.wikipedia.org/wiki/American_and_British_English_spelling_differences (not 100% obvious, but I could easily interpret it as 'advertise' is the right one)
Attachment #475895 - Flags: superreview?(neil) → superreview+
To conclude, Stefan's Wikipedia link in comment #10 holds the key: "advertise" is not of Greek origin, thus it shouldn't be "-ize"ified in American English.
Comment on attachment 475895 [details] [diff] [review]
Simple fix [Checkin: Comment 14]

Thanks for this patch r=me :)
Attachment #475895 - Flags: review?(iann_bugzilla) → review+
Thanks for the reviews, push on comm-central please.
Keywords: checkin-needed
Whiteboard: [c-n: comm-central]
Comment on attachment 475895 [details] [diff] [review]
Simple fix [Checkin: Comment 14]

http://hg.mozilla.org/comm-central/rev/0a06605db9b0
Attachment #475895 - Attachment description: Simple fix → Simple fix [Checkin: Comment 14]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: comm-central]
Target Milestone: --- → seamonkey2.1b1
You need to log in before you can comment on or make changes to this bug.